[ 
https://issues.apache.org/jira/browse/HIVE-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426276#comment-16426276
 ] 

Hive QA commented on HIVE-16612:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12867355/HIVE-16612.02.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9998/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9998/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9998/

Messages:
{noformat}
**** This message was trimmed, see log for full details ****
Checking out files:  76% (1082/1423)   
Checking out files:  77% (1096/1423)   
Checking out files:  78% (1110/1423)   
Checking out files:  79% (1125/1423)   
Checking out files:  80% (1139/1423)   
Checking out files:  81% (1153/1423)   
Checking out files:  82% (1167/1423)   
Checking out files:  83% (1182/1423)   
Checking out files:  84% (1196/1423)   
Checking out files:  85% (1210/1423)   
Checking out files:  86% (1224/1423)   
Checking out files:  87% (1239/1423)   
Checking out files:  88% (1253/1423)   
Checking out files:  89% (1267/1423)   
Checking out files:  90% (1281/1423)   
Checking out files:  91% (1295/1423)   
Checking out files:  92% (1310/1423)   
Checking out files:  93% (1324/1423)   
Checking out files:  94% (1338/1423)   
Checking out files:  95% (1352/1423)   
Checking out files:  96% (1367/1423)   
Checking out files:  97% (1381/1423)   
Checking out files:  98% (1395/1423)   
Checking out files:  99% (1409/1423)   
Checking out files: 100% (1423/1423)   
Checking out files: 100% (1423/1423), done.
HEAD is now at 078b9c3 HIVE-19100 : investigate TestStreaming failures(Eugene 
Koifman, reviewed by Alan Gates)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded.
  (use "git pull" to update your local branch)
+ git reset --hard origin/master
HEAD is now at dc5a943 HIVE-19083: Make partition clause optional for 
INSERT(Vineet Garg,reviewed by Ashutosh Chauhan)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-04-04 22:35:29.206
+ rm -rf ../yetus_PreCommit-HIVE-Build-9998
+ mkdir ../yetus_PreCommit-HIVE-Build-9998
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-9998
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-9998/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: does not 
exist in index
error: a/common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java: does 
not exist in index
error: 
a/metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/Driver.java: does not exist in 
index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java: does 
not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java: does 
not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java: does not 
exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java: does 
not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java:
 does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java: does 
not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/LocalSparkJobMonitor.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java: does 
not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MergeFileRecordProcessor.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/RecordProcessor.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java: does 
not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezProcessor.java: does 
not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java: does not 
exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/DAGSummary.java: 
does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/QueryExecutionBreakdownSummary.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java:
 does not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/hooks/ATSHook.java: does not 
exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java: does 
not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/log/LogDivertAppender.java: does 
not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: does not 
exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/Transform.java: does 
not exist in index
error: 
a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java: does 
not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java: does not 
exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java: 
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java: does 
not exist in index
error: 
a/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java: 
does not exist in index
error: patch failed: 
common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java:15
Falling back to three-way merge...
Applied patch to 
'common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java' with conflicts.
error: 
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java: 
does not exist in index
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/Driver.java:414
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/Driver.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java:51
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java:45
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:2298
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java' 
with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java:63
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java' 
cleanly.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java:88
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java:97
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java:36
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java'
 with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java:108
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java:25
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java'
 with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java:49
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java' 
with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/QueryExecutionBreakdownSummary.java:40
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/QueryExecutionBreakdownSummary.java'
 with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java:26
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java' 
with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java:568
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java' cleanly.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:471
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java' cleanly.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/log/LogDivertAppender.java:23
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/log/LogDivertAppender.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:131
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java' 
with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:138
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java:38
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java' 
with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java:61
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java' cleanly.
error: patch failed: 
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:57
Falling back to three-way merge...
Applied patch to 
'service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java' 
cleanly.
error: src/java/org/apache/hadoop/hive/conf/HiveConf.java: does not exist in 
index
error: src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java: does not exist 
in index
error: src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java: does 
not exist in index
error: src/java/org/apache/hadoop/hive/ql/Driver.java: does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java: does not 
exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java: 
does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java: 
does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/Utilities.java: does not exist 
in index
error: 
src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java: does 
not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java: does not 
exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java: 
does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java: 
does not exist in index
error: 
src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java: 
does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java: does not 
exist in index
error: 
src/java/org/apache/hadoop/hive/ql/exec/spark/status/LocalSparkJobMonitor.java: 
does not exist in index
error: 
src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java:
 does not exist in index
error: 
src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java: does 
not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java: 
does not exist in index
error: 
src/java/org/apache/hadoop/hive/ql/exec/tez/MergeFileRecordProcessor.java: does 
not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/RecordProcessor.java: does 
not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java: 
does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java: 
does not exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/TezProcessor.java: does not 
exist in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java: does not exist 
in index
error: src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/DAGSummary.java: 
does not exist in index
error: 
src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/QueryExecutionBreakdownSummary.java:
 does not exist in index
error: 
src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java: 
does not exist in index
error: 
src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java: does 
not exist in index
error: src/java/org/apache/hadoop/hive/ql/hooks/ATSHook.java: does not exist in 
index
error: src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: does 
not exist in index
error: src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java: does not 
exist in index
error: src/java/org/apache/hadoop/hive/ql/log/LogDivertAppender.java: does not 
exist in index
error: src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: does not exist in 
index
error: src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java: 
does not exist in index
error: src/java/org/apache/hadoop/hive/ql/optimizer/Transform.java: does not 
exist in index
error: src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java: 
does not exist in index
error: src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java: does not 
exist in index
error: src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java: does not 
exist in index
error: src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java: does 
not exist in index
error: src/java/org/apache/hadoop/hive/ql/session/SessionState.java: does not 
exist in index
error: src/java/org/apache/hive/service/cli/operation/SQLOperation.java: does 
not exist in index
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12867355 - PreCommit-HIVE-Build

> PerfLogger is configurable, but not extensible
> ----------------------------------------------
>
>                 Key: HIVE-16612
>                 URL: https://issues.apache.org/jira/browse/HIVE-16612
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Planning, Query Processor
>            Reporter: Remus Rusanu
>            Assignee: Remus Rusanu
>            Priority: Minor
>         Attachments: HIVE-16612.01.patch, HIVE-16612.02.patch
>
>
> {code}
>           result = (PerfLogger) 
> ReflectionUtils.newInstance(conf.getClassByName(
>             conf.getVar(HiveConf.ConfVars.HIVE_PERF_LOGGER)), conf);
> {code}
> The PerfLogger instance is configurable via {{hive.exec.perf.logger}} 
> (HIVE-11891) but the requirement to extend from {{PerfLogger}} cannot be met 
> since HIVE-11149 as the ctor is private. Also useful methods in PerfLogger 
> are also private. I tried to extend PerfLogger for my needs and realized 
> that, as is, the configurability is not usable. At the very least the 
> PerfLogger should make all private members {{protected}}, better the 
> requirement should be an interface not a class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to