[ https://issues.apache.org/jira/browse/HIVE-19158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446719#comment-16446719 ]
Marta Kuczora commented on HIVE-19158: -------------------------------------- Thanks a lot [~stakiar] for committing the patch. > Fix NPE in the HiveMetastore add partition tests > ------------------------------------------------ > > Key: HIVE-19158 > URL: https://issues.apache.org/jira/browse/HIVE-19158 > Project: Hive > Issue Type: Bug > Components: Metastore, Test > Reporter: Marta Kuczora > Assignee: Marta Kuczora > Priority: Minor > Fix For: 3.1.0 > > Attachments: HIVE-19158.1.patch, HIVE-19158.2.patch, > HIVE-19158.3.patch > > > The TestAddPartitions and TestAddPartitionsFromPartSpec tests revealed that > NPE is thrown in some cases. These NPEs could be prevented with a simple null > check and a MetaException with a proper error message should be thrown > instead. > Example: NPE is thrown in the following test cases > * TestAddPartitions > ** testAddPartitionNullPartition > ** testAddPartitionNullValue > ** testAddPartitionsNullList > * TestAddPartitionsFromPartSpec > ** testAddPartitionSpecNullSpec > ** testAddPartitionSpecNullPartList > ** testAddPartitionSpecNoDB > ** testAddPartitionSpecNoTable > ** testAddPartitionSpecNoDBAndTableInPartition > ** testAddPartitionSpecNullPart > ** testAddPartitionSpecChangeRootPathToNull > ** testAddPartitionSpecWithSharedSDNullSd > ** testAddPartitionSpecWithSharedSDNoValue > ** testAddPartitionSpecNullValue -- This message was sent by Atlassian JIRA (v7.6.3#76005)