[ https://issues.apache.org/jira/browse/HIVE-19247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449933#comment-16449933 ]
Hive QA commented on HIVE-19247: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 0s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 13s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 46s{color} | {color:red} ql: The patch generated 93 new + 223 unchanged - 8 fixed = 316 total (was 231) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 30s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10461/dev-support/hive-personality.sh | | git revision | master / 56c3a95 | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-10461/yetus/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-10461/yetus/whitespace-eol.txt | | modules | C: itests ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-10461/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > StatsOptimizer: Missing stats fast-path for Date > ------------------------------------------------ > > Key: HIVE-19247 > URL: https://issues.apache.org/jira/browse/HIVE-19247 > Project: Hive > Issue Type: Bug > Components: Statistics > Affects Versions: 2.2.0, 3.0.0, 2.3.2 > Reporter: Gopal V > Assignee: Gopal V > Priority: Major > Attachments: HIVE-19247.1.patch > > > {code} > 2018-04-19T18:57:24,268 DEBUG [67259108-c184-4c92-9e18-9e2969244442 > HiveServer2-Handler-Pool: Thread-73]: optimizer.StatsOptimizer > (StatsOptimizer.java:process(614)) - Unsupported type: date encountered in > metadata optimizer for column : jour > {code} > {code} > if (udaf instanceof GenericUDAFMin) { > ExprNodeColumnDesc colDesc = > (ExprNodeColumnDesc)exprMap.get(((ExprNodeColumnDesc)aggr.getParameters().get(0)).getColumn()); > String colName = colDesc.getColumn(); > StatType type = getType(colDesc.getTypeString()); > if (!tbl.isPartitioned()) { > if > (!StatsSetupConst.areColumnStatsUptoDate(tbl.getParameters(), colName)) { > Logger.debug("Stats for table : " + tbl.getTableName() + " > column " + colName > + " are not up to date."); > return null; > } > ColumnStatisticsData statData = > hive.getMSC().getTableColumnStatistics( > tbl.getDbName(), tbl.getTableName(), > Lists.newArrayList(colName)) > .get(0).getStatsData(); > String name = colDesc.getTypeString().toUpperCase(); > switch (type) { > case Integeral: { > LongSubType subType = LongSubType.valueOf(name); > LongColumnStatsData lstats = statData.getLongStats(); > if (lstats.isSetLowValue()) { > oneRow.add(subType.cast(lstats.getLowValue())); > } else { > oneRow.add(null); > } > break; > } > case Double: { > DoubleSubType subType = DoubleSubType.valueOf(name); > DoubleColumnStatsData dstats = statData.getDoubleStats(); > if (dstats.isSetLowValue()) { > oneRow.add(subType.cast(dstats.getLowValue())); > } else { > oneRow.add(null); > } > break; > } > default: // unsupported type > Logger.debug("Unsupported type: " + colDesc.getTypeString() > + " encountered in " + > "metadata optimizer for column : " + colName); > return null; > } > } > {code} > {code} > enum StatType{ > Integeral, > Double, > String, > Boolean, > Binary, > Unsupported > } > enum LongSubType { > BIGINT { @Override > Object cast(long longValue) { return longValue; } }, > INT { @Override > Object cast(long longValue) { return (int)longValue; } }, > SMALLINT { @Override > Object cast(long longValue) { return (short)longValue; } }, > TINYINT { @Override > Object cast(long longValue) { return (byte)longValue; } }; > abstract Object cast(long longValue); > } > {code} > Date is stored in stats (& also the typo there). -- This message was sent by Atlassian JIRA (v7.6.3#76005)