[ https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453071#comment-16453071 ]
Sahil Takiar commented on HIVE-19212: ------------------------------------- [~szita] attached an updated patch that downloads the FindBugs distribution to the scratch dir. Looks like the scratch dir is automatically cleaned up after every build already. I tested this manually on the hiveptest-server and FindBugs works, here is the output of running {{bash yetus-exec.sh}} {code} tomcat@hiveptest-server-upstream:/data/hiveptest/working/scratch/PreCommit-HIVE-Build-10177$ bash yetus-exec.sh + date '+%Y-%m-%d %T.%3N' 2018-04-25 19:25:35.780 + FINDBUGS_VERSION=3.0.1 + FINDBUGS_BASEURL=http://prdownloads.sourceforge.net/findbugs/ + FINDBUGS_TARBALL=findbugs-3.0.1.tar + pushd /data/hiveptest/working/scratch/PreCommit-HIVE-Build-10177 /data/hiveptest/working/scratch/PreCommit-HIVE-Build-10177 /data/hiveptest/working/scratch/PreCommit-HIVE-Build-10177 + curl -f -s -L -O http://prdownloads.sourceforge.net/findbugs//findbugs-3.0.1.tar.gz + [[ 0 != 0 ]] + gunzip -c findbugs-3.0.1.tar.gz + tar xpf - + [[ 0 != 0 ]] + popd /data/hiveptest/working/scratch/PreCommit-HIVE-Build-10177 + export FINDBUGS_HOME=/data/hiveptest/working/scratch/PreCommit-HIVE-Build-10177/findbugs-3.0.1 + FINDBUGS_HOME=/data/hiveptest/working/scratch/PreCommit-HIVE-Build-10177/findbugs-3.0.1 + pushd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177 /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177 /data/hiveptest/working/scratch/PreCommit-HIVE-Build-10177 + export JIRA_ISSUE=HIVE-19108 + JIRA_ISSUE=HIVE-19108 + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + ./dev-support/test-patch.sh /data/hiveptest/logs/PreCommit-HIVE-Build-10177/patches/PreCommit-HIVE-Build-10177.patch --jenkins --jira-base-url=https://issues.apache.org/jira --jira-user=hiveqa '--jira-password=c0mmit!' --patch-dir=/data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus --build-url=http://104.198.109.242/logs//PreCommit-HIVE-Build-10177/ --build-url-console=yetus.txt --build-url-artifacts=yetus Modes: Jenkins Robot ResetRepo UnitTests Processing: /data/hiveptest/logs/PreCommit-HIVE-Build-10177/patches/PreCommit-HIVE-Build-10177.patch ============================================================================ ============================================================================ Confirming git environment ============================================================================ ============================================================================ HEAD is now at 0b6967e HIVE-19215 : JavaUtils.AnyIdDirFilter ignores base_n directories (Sergey Shelukhin, reviewed by Prasanth Jayachandran) Removing classification/target/ Removing patchprocess/ Removing shims/common/target/ Removing storage-api/target/ Removing target/ Already on 'master' Your branch is up-to-date with 'origin/master'. Current branch master is up to date. Already on 'master' Your branch is up-to-date with 'origin/master'. HEAD is now at 0b6967e HIVE-19215 : JavaUtils.AnyIdDirFilter ignores base_n directories (Sergey Shelukhin, reviewed by Prasanth Jayachandran) Testing /data/hiveptest/logs/PreCommit-HIVE-Build-10177/patches/PreCommit-HIVE-Build-10177.patch patch on master. ============================================================================ ============================================================================ Determining needed tests ============================================================================ ============================================================================ (Depending upon input size and number of plug-ins, this may take a while) ============================================================================ ============================================================================ Checking for @author tags: patch ============================================================================ ============================================================================ There appear to be 0 @author tags in the patch. ============================================================================ ============================================================================ maven install: master ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177 mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/branch-mvninstall-root.txt 2>&1 Elapsed: 6m 26s ============================================================================ ============================================================================ master compilation: pre-patch ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn -DskipTests -Pitests clean test-compile -DskipTests=true > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/branch-compile-spark-client.txt 2>&1 Elapsed: 0m 18s ============================================================================ ============================================================================ checkstyle: master ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DskipTests -Pitests -Ptest-patch > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/maven-branch-checkstyle-spark-client.txt 2>&1 ============================================================================ ============================================================================ findbugs detection: master ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn -DskipTests -Pitests,findbugs test-compile findbugs:findbugs -DskipTests=true > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/branch-findbugs-spark-client.txt 2>&1 Elapsed: 0m 27s spark-client in master has 15 extant Findbugs warnings. ============================================================================ ============================================================================ Pre-patch javadoc verification on master ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn -DskipTests -Pitests,javadoc clean javadoc:javadoc -DskipTests=true > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/branch-javadoc-spark-client.txt 2>&1 Elapsed: 0m 13s ============================================================================ ============================================================================ Cleaning the source tree ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn -DskipTests -Pitests clean -DskipTests=true > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/branch-distclean-spark-client.txt 2>&1 Elapsed: 0m 5s ============================================================================ ============================================================================ Applying patch to master ============================================================================ ============================================================================ Applying the patch: Wed Apr 25 19:21:47 UTC 2018 cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177 git apply --binary -v --stat --apply -p1 /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/patch Applied patch spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java cleanly. .../org/apache/hive/spark/client/RemoteDriver.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Wed Apr 25 19:33:28 UTC 2018 cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177 git apply --binary -v --stat --apply -p1 /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/patch Applied patch spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java cleanly. .../org/apache/hive/spark/client/RemoteDriver.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ============================================================================ ============================================================================ maven install: patch ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn -DskipTests -Pitests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/patch-mvninstall-spark-client.txt 2>&1 Elapsed: 0m 18s ============================================================================ ============================================================================ master compilation: patch ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn -DskipTests -Pitests clean test-compile -DskipTests=true > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/patch-compile-spark-client.txt 2>&1 Elapsed: 0m 16s ============================================================================ ============================================================================ checkstyle: patch ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DskipTests -Pitests -Ptest-patch > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/maven-patch-checkstyle-spark-client.txt 2>&1 ============================================================================ ============================================================================ Checking for whitespace issues. ============================================================================ ============================================================================ ============================================================================ ============================================================================ findbugs detection: patch ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn -DskipTests -Pitests,findbugs test-compile findbugs:findbugs -DskipTests=true > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/patch-findbugs-spark-client.txt 2>&1 Elapsed: 0m 28s Starting with /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/branch-findbugs-spark-client-warnings.xml Merging /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/patch-findbugs-spark-client-warnings.xml Writing /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/combined-findbugs-spark-client.xml ============================================================================ ============================================================================ javadoc verification: patch ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/spark-client mvn -DskipTests -Pitests,javadoc clean javadoc:javadoc -DskipTests=true > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/patch-javadoc-spark-client.txt 2>&1 Elapsed: 0m 11s ============================================================================ ============================================================================ Determining number of ASF License errors ============================================================================ ============================================================================ cd /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177 mvn -fn apache-rat:check > /data/hiveptest/logs/PreCommit-HIVE-Build-10177/yetus/patch-asflicense-root.txt 2>&1 Elapsed: 0m 13s There appear to be 0 ASF License warnings after applying the patch. Total Elapsed time: 9m 36s ============================================================================ ============================================================================ Adding comment to JIRA ============================================================================ ============================================================================ +1 overall | Vote | Subsystem | Runtime | Comment ============================================================================ | | | | Prechecks | +1 | @author | 0m 0s | The patch does not contain any @author | | | | tags. | | | | master Compile Tests | +1 | mvninstall | 6m 26s | master passed | +1 | compile | 0m 18s | master passed | +1 | checkstyle | 0m 11s | master passed | 0 | findbugs | 0m 29s | spark-client in master has 15 extant | | | | Findbugs warnings. | +1 | javadoc | 0m 13s | master passed | | | | Patch Compile Tests | +1 | mvninstall | 0m 18s | the patch passed | +1 | compile | 0m 16s | the patch passed | +1 | javac | 0m 16s | the patch passed | +1 | checkstyle | 0m 10s | the patch passed | +1 | whitespace | 0m 0s | The patch has no whitespace issues. | +1 | findbugs | 0m 38s | the patch passed | +1 | javadoc | 0m 11s | the patch passed | | | | Other Tests | +1 | asflicense | 0m 13s | The patch does not generate ASF License | | | | warnings. | | | 9m 36s | || Subsystem || Report/Notes || ============================================================================ | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177/dev-support/hive-personality.sh | | git revision | master / 0b6967e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: spark-client U: spark-client | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-10177/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | ============================================================================ ============================================================================ Finished build. ============================================================================ ============================================================================ + popd /data/hiveptest/working/scratch/PreCommit-HIVE-Build-10177 + rm -rf /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10177 {code} > Fix findbugs yetus pre-commit checks > ------------------------------------ > > Key: HIVE-19212 > URL: https://issues.apache.org/jira/browse/HIVE-19212 > Project: Hive > Issue Type: Sub-task > Components: Testing Infrastructure > Reporter: Sahil Takiar > Assignee: Sahil Takiar > Priority: Major > Attachments: HIVE-19212.1.patch, HIVE-19212.2.patch > > > Follow up from HIVE-18883, the committed patch isn't working and Findbugs is > still not working. -- This message was sent by Atlassian JIRA (v7.6.3#76005)