[ https://issues.apache.org/jira/browse/HIVE-19424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473523#comment-16473523 ]
Hive QA commented on HIVE-19424: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 12s{color} | {color:blue} ql in master has 2321 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 10s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10898/dev-support/hive-personality.sh | | git revision | master / 6f9368b | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-10898/yetus/whitespace-eol.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-10898/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > NPE In MetaDataFormatters > ------------------------- > > Key: HIVE-19424 > URL: https://issues.apache.org/jira/browse/HIVE-19424 > Project: Hive > Issue Type: Bug > Components: HiveServer2, Metastore, Standalone Metastore > Affects Versions: 3.0.0, 2.4.0 > Reporter: BELUGA BEHR > Assignee: Alice Fan > Priority: Minor > Attachments: HIVE-19424.1.patch > > > h2. Overview > According to the Hive Schema definition, a table's {{INPUT_FORMAT}} class can > be set to NULL. However, there are places in the code where we do not > account for this NULL value, in particular the {{MetaDataFormatters}} classes > {{TextMetaDataFormatter}} and {{JsonMetaDataFormatter}}. In addition, there > is no debug level logging in the {{MetaDataFormatters}} classes to tell me > which table in particular is causing the problem. > {code:sql|title=hive-schema-2.2.0.mysql.sql} > CREATE TABLE IF NOT EXISTS `SDS` ( > `SD_ID` bigint(20) NOT NULL, > `CD_ID` bigint(20) DEFAULT NULL, > `INPUT_FORMAT` varchar(4000) CHARACTER SET latin1 COLLATE latin1_bin > DEFAULT NULL, > `IS_COMPRESSED` bit(1) NOT NULL, > ... > {code} > {code:java|title=TextMetaDataFormatter.java} > // Not checking for a null return from getInputFormatClass > inputFormattCls = par.getInputFormatClass().getName(); > outputFormattCls = par.getOutputFormatClass().getName(); > {code} > h2. Reproduction > {code:sql} > -- MySQL Backend > update SDS SET INPUT_FORMAT=NULL WHERE SD_ID=XXX; > {code} > {code} > // Hive > SHOW TABLE EXTENDED FROM default LIKE '*'; > // HS2 Logs > [HiveServer2-Background-Pool: Thread-464]: Error running hive query: > org.apache.hive.service.cli.HiveSQLException: Error while processing > statement: FAILED: Execution Error, return code 1 from > org.apache.hadoop.hive.ql.exec.DDLTask. Exception while processing show table > status > at > org.apache.hive.service.cli.operation.Operation.toSQLException(Operation.java:400) > at > org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:238) > at > org.apache.hive.service.cli.operation.SQLOperation.access$300(SQLOperation.java:89) > at > org.apache.hive.service.cli.operation.SQLOperation$3$1.run(SQLOperation.java:301) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:422) > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1920) > at > org.apache.hive.service.cli.operation.SQLOperation$3.run(SQLOperation.java:314) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Exception while > processing show table status > at > org.apache.hadoop.hive.ql.exec.DDLTask.showTableStatus(DDLTask.java:3025) > at org.apache.hadoop.hive.ql.exec.DDLTask.execute(DDLTask.java:405) > at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:214) > at > org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:99) > at org.apache.hadoop.hive.ql.Driver.launchTask(Driver.java:2052) > at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1748) > at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1501) > at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1285) > at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1280) > at > org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:236) > ... 11 more > Caused by: java.lang.NullPointerException > at > org.apache.hadoop.hive.ql.metadata.formatting.TextMetaDataFormatter.showTableStatus(TextMetaDataFormatter.java:202) > at > org.apache.hadoop.hive.ql.exec.DDLTask.showTableStatus(DDLTask.java:3020) > ... 20 more > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)