[
https://issues.apache.org/jira/browse/HIVE-19384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473793#comment-16473793
]
Hive QA commented on HIVE-19384:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
23s{color} | {color:blue} storage-api in master has 48 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
51s{color} | {color:blue} ql in master has 2321 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
30s{color} | {color:red} ql in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
10s{color} | {color:red} storage-api: The patch generated 2 new + 12 unchanged
- 2 fixed = 14 total (was 14) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 74 new + 608 unchanged - 16
fixed = 682 total (was 624) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} vector-code-gen: The patch generated 3 new + 316
unchanged - 0 fixed = 319 total (was 316) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
1s{color} | {color:red} ql generated 8 new + 2320 unchanged - 1 fixed = 2328
total (was 2321) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 5s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprIntervalDayTimeColumnScalar
defines non-transient non-serializable instance field arg3Scalar In
IfExprIntervalDayTimeColumnScalar.java:instance field arg3Scalar In
IfExprIntervalDayTimeColumnScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprIntervalDayTimeScalarColumn
defines non-transient non-serializable instance field arg2Scalar In
IfExprIntervalDayTimeScalarColumn.java:instance field arg2Scalar In
IfExprIntervalDayTimeScalarColumn.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprIntervalDayTimeScalarScalar
defines non-transient non-serializable instance field arg2Scalar In
IfExprIntervalDayTimeScalarScalar.java:instance field arg2Scalar In
IfExprIntervalDayTimeScalarScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprIntervalDayTimeScalarScalar
defines non-transient non-serializable instance field arg3Scalar In
IfExprIntervalDayTimeScalarScalar.java:instance field arg3Scalar In
IfExprIntervalDayTimeScalarScalar.java |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprTimestampColumnScalar(int,
int, Timestamp, int) may expose internal representation by storing an
externally mutable object into IfExprTimestampColumnScalar.arg3Scalar At
IfExprTimestampColumnScalar.java:may expose internal representation by storing
an externally mutable object into IfExprTimestampColumnScalar.arg3Scalar At
IfExprTimestampColumnScalar.java:[line 48] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprTimestampScalarColumn(int,
Timestamp, int, int) may expose internal representation by storing an
externally mutable object into IfExprTimestampScalarColumn.arg2Scalar At
IfExprTimestampScalarColumn.java:may expose internal representation by storing
an externally mutable object into IfExprTimestampScalarColumn.arg2Scalar At
IfExprTimestampScalarColumn.java:[line 47] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprTimestampScalarScalar(int,
Timestamp, Timestamp, int) may expose internal representation by storing an
externally mutable object into IfExprTimestampScalarScalar.arg2Scalar At
IfExprTimestampScalarScalar.java:may expose internal representation by storing
an externally mutable object into IfExprTimestampScalarScalar.arg2Scalar At
IfExprTimestampScalarScalar.java:[line 49] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprTimestampScalarScalar(int,
Timestamp, Timestamp, int) may expose internal representation by storing an
externally mutable object into IfExprTimestampScalarScalar.arg3Scalar At
IfExprTimestampScalarScalar.java:may expose internal representation by storing
an externally mutable object into IfExprTimestampScalarScalar.arg3Scalar At
IfExprTimestampScalarScalar.java:[line 50] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-10921/dev-support/hive-personality.sh
|
| git revision | master / f327624 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10921/yetus/patch-mvninstall-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10921/yetus/diff-checkstyle-storage-api.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10921/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10921/yetus/diff-checkstyle-vector-code-gen.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10921/yetus/new-findbugs-ql.html
|
| modules | C: storage-api ql vector-code-gen U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10921/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Vectorization: IfExprTimestamp* do not handle NULLs correctly
> -------------------------------------------------------------
>
> Key: HIVE-19384
> URL: https://issues.apache.org/jira/browse/HIVE-19384
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: Matt McCline
> Assignee: Matt McCline
> Priority: Blocker
> Fix For: 3.0.0, 3.1.0
>
> Attachments: HIVE-19384.01.patch, HIVE-19384.02.patch,
> HIVE-19384.04.patch, HIVE-19384.05.patch
>
>
> HIVE-18622: "Vectorization: IF Statements, Comparisons, and more do not
> handle NULLs correctly" didn't quite fix the IfExprTimestamp* classes
> right....
> {noformat}
> // Carefully handle NULLs...
> outputColVector.noNulls = false;{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
