[ 
https://issues.apache.org/jira/browse/HIVE-19501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475146#comment-16475146
 ] 

Hive QA commented on HIVE-19501:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12923273/HIVE-19501.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 19 failed/errored test(s), 14397 tests 
executed
*Failed tests:*
{noformat}
TestNonCatCallsWithCatalog - did not produce a TEST-*.xml file (likely timed 
out) (batchId=217)
TestTxnExIm - did not produce a TEST-*.xml file (likely timed out) (batchId=286)
org.apache.hadoop.hive.cli.TestMiniDruidKafkaCliDriver.testCliDriver[druidkafkamini_basic]
 (batchId=253)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainuser_4]
 (batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_dynpart_hashjoin_1]
 (batchId=174)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut 
(batchId=225)
org.apache.hadoop.hive.metastore.TestStats.partitionedTableInHiveCatalog 
(batchId=211)
org.apache.hadoop.hive.ql.TestAutoPurgeTables.testAutoPurgeInvalid (batchId=233)
org.apache.hadoop.hive.ql.TestAutoPurgeTables.testAutoPurgeUnset (batchId=233)
org.apache.hadoop.hive.ql.TestAutoPurgeTables.testPartitionedNoAutoPurge 
(batchId=233)
org.apache.hadoop.hive.ql.TestAutoPurgeTables.testTruncateNoAutoPurge 
(batchId=233)
org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgress (batchId=236)
org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgressParallel 
(batchId=236)
org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testMapNullKey[2] 
(batchId=196)
org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testSyntheticComplexSchema[1]
 (batchId=196)
org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testTupleInBagInTupleInBag[1]
 (batchId=196)
org.apache.hive.hcatalog.pig.TestRCFileHCatStorer.testWriteChar (batchId=196)
org.apache.hive.hcatalog.pig.TestRCFileHCatStorer.testWriteDate2 (batchId=196)
org.apache.hive.jdbc.TestTriggersMoveWorkloadManager.testTriggerMoveAndKill 
(batchId=240)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/10950/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/10950/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-10950/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 19 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12923273 - PreCommit-HIVE-Build

> Fix HyperLogLog to be threadsafe
> --------------------------------
>
>                 Key: HIVE-19501
>                 URL: https://issues.apache.org/jira/browse/HIVE-19501
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Laszlo Bodor
>            Priority: Major
>         Attachments: HIVE-19501.01.patch
>
>
> not sure if this is an issue in reality or not; but there are 3 static fields 
> in HyperLogLog which are rewritten during working; if there are multiple 
> threads are calculating HLL in the same JVM, there is a theoretical chance 
> that they might overwrite eachothers value...
> static fields:
> https://github.com/apache/hive/blob/8028ce8a4cf5a03e2998c33e032a511fae770b47/standalone-metastore/src/main/java/org/apache/hadoop/hive/common/ndv/hll/HyperLogLog.java#L65
> usage:
> https://github.com/apache/hive/blob/8028ce8a4cf5a03e2998c33e032a511fae770b47/standalone-metastore/src/main/java/org/apache/hadoop/hive/common/ndv/hll/HyperLogLog.java#L216



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to