[ https://issues.apache.org/jira/browse/HIVE-19326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489902#comment-16489902 ]
Hive QA commented on HIVE-19326: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 44s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 48s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 46s{color} | {color:blue} itests/util in master has 55 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 6s{color} | {color:blue} ql in master has 2322 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 6s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 9s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 52s{color} | {color:red} root: The patch generated 1 new + 332 unchanged - 18 fixed = 333 total (was 350) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 40s{color} | {color:red} ql: The patch generated 1 new + 304 unchanged - 18 fixed = 305 total (was 322) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 6 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 58m 25s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense xml javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11189/dev-support/hive-personality.sh | | git revision | master / 68a2bea | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-11189/yetus/diff-checkstyle-root.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-11189/yetus/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-11189/yetus/whitespace-eol.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-11189/yetus/whitespace-tabs.txt | | modules | C: . itests itests/util ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11189/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > stats auto gather: incorrect aggregation during UNION queries (may lead to > incorrect results) > --------------------------------------------------------------------------------------------- > > Key: HIVE-19326 > URL: https://issues.apache.org/jira/browse/HIVE-19326 > Project: Hive > Issue Type: Bug > Components: Statistics > Reporter: Sergey Shelukhin > Assignee: Zoltan Haindrich > Priority: Critical > Attachments: HIVE-19326.01wip01.patch, HIVE-19326.02.patch, > HIVE-19326.03.patch, HIVE-19326.04.patch, HIVE-19326.05.patch, > HIVE-19326.06wip01.patch > > > Found when investigating the results change after converting tables to MM, > turns out the MM result is correct but the current one is not. > The test ends like so: > {noformat} > desc formatted small_alltypesorc_a; > ANALYZE TABLE small_alltypesorc_a COMPUTE STATISTICS; > desc formatted small_alltypesorc_a; > insert into table small_alltypesorc_a select * from small_alltypesorc1a; > desc formatted small_alltypesorc_a; > {noformat} > The results from the descs in the golden file are: > {noformat} > COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\"} > numFiles 1 > numRows 5 > ... > COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\"} > numFiles 1 > numRows 15 > ... > COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\"} > numFiles 2 > numRows 20 > {noformat} > Note the result change after analyze - the original nomRows is inaccurate, > but BASIC_STATS is set to true. > I am assuming with metadata only optimization this can produce incorrect > results. -- This message was sent by Atlassian JIRA (v7.6.3#76005)