[
https://issues.apache.org/jira/browse/HIVE-19490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492770#comment-16492770
]
Hive QA commented on HIVE-19490:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12925311/HIVE-19490.7.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14409 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11302/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11302/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11302/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12925311 - PreCommit-HIVE-Build
> Locking on Insert into for non native and managed tables.
> ---------------------------------------------------------
>
> Key: HIVE-19490
> URL: https://issues.apache.org/jira/browse/HIVE-19490
> Project: Hive
> Issue Type: Improvement
> Components: Druid integration
> Reporter: slim bouguerra
> Assignee: slim bouguerra
> Priority: Blocker
> Labels: druid, locking
> Attachments: HIVE-19490.2.patch, HIVE-19490.3.patch,
> HIVE-19490.4.patch, HIVE-19490.5.patch, HIVE-19490.6.patch,
> HIVE-19490.6.patch, HIVE-19490.7.patch, HIVE-19490.patch
>
>
> Current state of the art:
> Managed non native table like Druid Tables, will need to get a Lock on Insert
> into or insert Over write. The nature of this lock is set to Exclusive by
> default for any non native table.
> This implies that Inserts into Druid table will Lock any read query as well
> during the execution of the insert into. IMO this lock (on insert into) is
> not needed since the insert statement is appending data and the state of
> loading it is managed partially by Hive Storage handler hook and part of it
> by Druid.
> What i am proposing is to relax the lock level to shared for all non native
> tables on insert into operations and keep it as Exclusive Write for insert
> Overwrite for now.
>
> Any feedback is welcome.
> cc [~ekoifman] / [~ashutoshc] / [~jdere] / [~hagleitn]
> Also am not sure what is the best way to unit test this currently am using
> debugger to check if locks are what i except, please let me know if there is
> a better way to do this.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
