[ https://issues.apache.org/jira/browse/HIVE-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494588#comment-16494588 ]
Hive QA commented on HIVE-17852: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12925471/HIVE-17852.04.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11350/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11350/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11350/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-05-30 02:16:28.730 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-11350/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-05-30 02:16:28.733 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 0cb2a6c HIVE-19323 Create metastore SQL install and upgrade scripts for 3.1 and 4.0 (Alan Gates, reviewed by Vihang Karajgaonkar) + git clean -f -d Removing itests/${project.basedir}/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 0cb2a6c HIVE-19323 Create metastore SQL install and upgrade scripts for 3.1 and 4.0 (Alan Gates, reviewed by Vihang Karajgaonkar) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-05-30 02:16:29.973 + rm -rf ../yetus_PreCommit-HIVE-Build-11350 + mkdir ../yetus_PreCommit-HIVE-Build-11350 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-11350 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-11350/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/derby/hive-schema-4.0.0.derby.sql' with conflicts. Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql' with conflicts. Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql' with conflicts. Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql' with conflicts. Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql' with conflicts. Going to apply patch with: git apply -p0 /data/hiveptest/working/scratch/build.patch:3799: trailing whitespace. numFiles 1 /data/hiveptest/working/scratch/build.patch:3859: trailing whitespace. numFiles 1 /data/hiveptest/working/scratch/build.patch:3863: trailing whitespace. totalSize 5293 /data/hiveptest/working/scratch/build.patch:3902: trailing whitespace. numFiles 1 /data/hiveptest/working/scratch/build.patch:3923: trailing whitespace. numFiles 1 Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/derby/hive-schema-4.0.0.derby.sql' with conflicts. Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql' with conflicts. Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql' with conflicts. Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql' with conflicts. Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql' with conflicts. U standalone-metastore/src/main/sql/derby/hive-schema-4.0.0.derby.sql U standalone-metastore/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql U standalone-metastore/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql U standalone-metastore/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql U standalone-metastore/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql warning: squelched 52 whitespace errors warning: 57 lines add whitespace errors. + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-11350 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12925471 - PreCommit-HIVE-Build > remove support for list bucketing "stored as directories" in 3.0 > ---------------------------------------------------------------- > > Key: HIVE-17852 > URL: https://issues.apache.org/jira/browse/HIVE-17852 > Project: Hive > Issue Type: Bug > Reporter: Sergey Shelukhin > Assignee: Laszlo Bodor > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-17852.01.patch, HIVE-17852.02.patch, > HIVE-17852.03.patch, HIVE-17852.04.patch > > > From the email thread: > 1) LB, when stored as directories, adds a lot of low-level complexity to Hive > tables that has to be accounted for in many places in the code where the > files are written or modified - from FSOP to ACID/replication/export. > 2) While working on some FSOP code I noticed that some of that logic is > broken - e.g. the duplicate file removal from tasks, a pretty fundamental > correctness feature in Hive, may be broken. LB also doesn’t appear to be > compatible with e.g. regular bucketing. > 3) The feature hasn’t seen development activity in a while; it also doesn’t > appear to be used a lot. > Keeping with the theme of cleaning up “legacy” code for 3.0, I was proposing > we remove it. > (2) also suggested that, if needed, it might be easier to implement similar > functionality by adding some flexibility to partitions (which LB directories > look like anyway); that would also keep the logic on a higher level of > abstraction (split generation, partition pruning) as opposed to many > low-level places like FSOP, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)