[ https://issues.apache.org/jira/browse/HIVE-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501850#comment-16501850 ]
Sahil Takiar commented on HIVE-19079: ------------------------------------- [~aihuaxu] after looking at this a bit more. I think it makes sense to keep the current naming. Technically, {{hive.spark.jobname.length}} is still just controlling the length of the job name (e.g. it controls the size of the value for {{mapreduce.job.name}} [here|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L2475]). Same with {{DagUtils#getQueryName}} - technically it is just getting the "query name" by reading the config {{hive.query.name}} and if that isn't set, it uses the {{mapreduce.job.name}} as a fallback - Tez does something similar [here|https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java#L1470]. The only difference is that {{HiveSparkClient}} interprets the "query name" as a "query description", but that doesn't change the fact that {{DagUtils#getQueryName}} is still returning the "query name". I've added some Javadocs to make this clearer. What do you think? > Add extended query string to Spark job description > -------------------------------------------------- > > Key: HIVE-19079 > URL: https://issues.apache.org/jira/browse/HIVE-19079 > Project: Hive > Issue Type: Sub-task > Components: Spark > Reporter: Sahil Takiar > Assignee: Sahil Takiar > Priority: Major > Attachments: HIVE-19079.1.patch, HIVE-19079.2.patch, > HIVE-19079.3.patch, HIVE-19079.4.patch, HIVE-19079.5.patch, Spark Collapse > Truncated Query.png, Spark Expanded Truncated Query.png > > > As of HIVE-16601, we place a shortened version of the query into the Spark > job description. We should look into adding a longer version of the query. It > seems that the Spark Web UI has a nice feature where long job descriptions > will be truncated with a {{...}}, but when you double click on the {{...}} it > expands to show the rest of the string. -- This message was sent by Atlassian JIRA (v7.6.3#76005)