[
https://issues.apache.org/jira/browse/HIVE-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502129#comment-16502129
]
Steve Loughran commented on HIVE-16391:
---------------------------------------
bq. The problem with that is that it changes the meaning of Hive's artifacts,
so anybody currently importing hive-exec would see a breakage, and that's
probably not desired.
probably true.
Obviously, its up to the hive team, but yes, the "purist" approach is unshaded
with a shaded option.
One issue I recall from building that 1.2.1-spark JAR was that a very small bit
of the hive API used by spark passed kryo objects around. It wasn't enough to
shade, we had to tweak the hive source to import the previous kryo package so
that all was in sync. If that is now fixed through: API changes, spark/hive
version changes, life is simpler. Ideally: an API which didn't pass shaded
classes around.
Where do things stand there?
> Publish proper Hive 1.2 jars (without including all dependencies in uber jar)
> -----------------------------------------------------------------------------
>
> Key: HIVE-16391
> URL: https://issues.apache.org/jira/browse/HIVE-16391
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 1.2.2
> Reporter: Reynold Xin
> Assignee: Saisai Shao
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.2.3
>
> Attachments: HIVE-16391.patch
>
>
> Apache Spark currently depends on a forked version of Apache Hive. AFAIK, the
> only change in the fork is to work around the issue that Hive publishes only
> two sets of jars: one set with no dependency declared, and another with all
> the dependencies included in the published uber jar. That is to say, Hive
> doesn't publish a set of jars with the proper dependencies declared.
> There is general consensus on both sides that we should remove the forked
> Hive.
> The change in the forked version is recorded here
> https://github.com/JoshRosen/hive/tree/release-1.2.1-spark2
> Note that the fork in the past included other fixes but those have all become
> unnecessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
