[ https://issues.apache.org/jira/browse/HIVE-19971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521227#comment-16521227 ]
Peter Vary commented on HIVE-19971: ----------------------------------- +1 LGTM - Although I do not like arbitrary sleeps in tests, but this is good as a temporary fix for sure. > TestRuntimeStats.testCleanup() is flaky > --------------------------------------- > > Key: HIVE-19971 > URL: https://issues.apache.org/jira/browse/HIVE-19971 > Project: Hive > Issue Type: Task > Reporter: Andrew Sherman > Assignee: Andrew Sherman > Priority: Major > Attachments: HIVE-19971.1.patch > > > This test is timing dependent and sometimes fails. [You can see that it > sometimes fails in otherwise clean > runs|https://issues.apache.org/jira/issues/?jql=text%20~%20%22TestRuntimeStats%22]. > The test inserts a stat, sleeps for 2 seconds, inserts another stat, then > deletes stats that are older than 1 second. The test asserts that exactly one > stat is deleted. If the deletion is slow for some reason (perhaps a GC?) then > 2 stats will be deleted and the test will fail. The trouble is that the 1 > second window is too small to work consistently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)