[ 
https://issues.apache.org/jira/browse/HIVE-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527196#comment-16527196
 ] 

Aihua Xu commented on HIVE-18916:
---------------------------------

[~stakiar] Right now we need to make tests clear before commit. Can you rebase 
your code? Otherwise, the change looks good to me. +1.

> SparkClientImpl doesn't error out if spark-submit fails
> -------------------------------------------------------
>
>                 Key: HIVE-18916
>                 URL: https://issues.apache.org/jira/browse/HIVE-18916
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>         Attachments: HIVE-18916.1.WIP.patch, HIVE-18916.2.patch, 
> HIVE-18916.3.patch, HIVE-18916.4.patch, HIVE-18916.5.patch, HIVE-18916.6.patch
>
>
> If {{spark-submit}} returns a non-zero exit code, {{SparkClientImpl}} will 
> simply log the exit code, but won't throw an error. Eventually, the 
> connection timeout will get triggered and an exception like {{Timed out 
> waiting for client connection}} will be logged, which is pretty misleading.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to