[ https://issues.apache.org/jira/browse/HIVE-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528552#comment-16528552 ]
Hive QA commented on HIVE-18882: -------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 54s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 6s{color} | {color:blue} standalone-metastore in master has 228 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 19m 30s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12267/dev-support/hive-personality.sh | | git revision | master / 761597f | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12267/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Do Not Hide Exception in Hive Metastore Client Connection > --------------------------------------------------------- > > Key: HIVE-18882 > URL: https://issues.apache.org/jira/browse/HIVE-18882 > Project: Hive > Issue Type: Improvement > Components: Standalone Metastore > Affects Versions: 3.0.0 > Reporter: BELUGA BEHR > Assignee: Manoj Narayanan > Priority: Minor > Labels: noob > Attachments: HIVE-18882.1.patch, HIVE-18882.2.patch, HIVE-18882.patch > > > [https://github.com/apache/hive/blob/4047befe48c8f762c58d8854e058385c1df151c6/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java#L526-L531] > > {code:java} > if (LOG.isDebugEnabled()) { > LOG.warn("Failed to connect to the MetaStore Server...", e); > } else { > // Don't print full exception trace if DEBUG is not on. > LOG.warn("Failed to connect to the MetaStore Server..."); > } > {code} > I do not understand the logic here. I always want to see the reason for the > failure. Otherwise, I do not know why it is failing unless I restart the > server with debug logging enabled. By that point, the error may have > cleared. Please just use the Exception in the WARN output without adding > confusing logging for debugging. This is never an expected behavior... that > enabling debug would change a _warn_ level log message. > Also... please remove the ellipsis, they add no value. -- This message was sent by Atlassian JIRA (v7.6.3#76005)