[ https://issues.apache.org/jira/browse/HIVE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529309#comment-16529309 ]
Hive QA commented on HIVE-19711: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 52s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 26s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 29s{color} | {color:blue} beeline in master has 70 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 38s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 36s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 3s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} beeline: The patch generated 12 new + 72 unchanged - 63 fixed = 84 total (was 135) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 53s{color} | {color:red} root: The patch generated 13 new + 238 unchanged - 93 fixed = 251 total (was 331) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 166 unchanged - 30 fixed = 167 total (was 196) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 37s{color} | {color:red} beeline generated 5 new + 51 unchanged - 19 fixed = 56 total (was 70) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 24s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 48m 20s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:beeline | | | org.apache.hive.beeline.BeeLineOpts.getInitFiles() may expose internal representation by returning BeeLineOpts.initFiles At BeeLineOpts.java:by returning BeeLineOpts.initFiles At BeeLineOpts.java:[line 469] | | | org.apache.hive.beeline.BeeLineOpts.setInitFiles(String[]) may expose internal representation by storing an externally mutable object into BeeLineOpts.initFiles At BeeLineOpts.java:by storing an externally mutable object into BeeLineOpts.initFiles At BeeLineOpts.java:[line 473] | | | org.apache.hive.beeline.BeeLineOpts.env should be package protected At BeeLineOpts.java: At BeeLineOpts.java:[line 143] | | | org.apache.hive.beeline.schematool.HiveSchemaToolTaskAlterCatalog.execute() passes a nonconstant String to an execute or addBatch method on an SQL statement At HiveSchemaToolTaskAlterCatalog.java:to an execute or addBatch method on an SQL statement At HiveSchemaToolTaskAlterCatalog.java:[line 70] | | | Found reliance on default encoding in org.apache.hive.beeline.schematool.HiveSchemaToolTaskValidate.findCreateTable(String, List):in org.apache.hive.beeline.schematool.HiveSchemaToolTaskValidate.findCreateTable(String, List): new java.io.FileReader(String) At HiveSchemaToolTaskValidate.java:[line 283] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12308/dev-support/hive-personality.sh | | git revision | master / 455b71e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12308/yetus/diff-checkstyle-beeline.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12308/yetus/diff-checkstyle-root.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12308/yetus/diff-checkstyle-itests_hive-unit.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12308/yetus/new-findbugs-beeline.html | | modules | C: beeline . itests/hive-unit U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12308/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Refactor Hive Schema Tool > ------------------------- > > Key: HIVE-19711 > URL: https://issues.apache.org/jira/browse/HIVE-19711 > Project: Hive > Issue Type: Bug > Components: Hive > Affects Versions: 3.0.0 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-19711.01.patch, HIVE-19711.02.patch, > HIVE-19711.03.patch, HIVE-19711.04.patch, HIVE-19711.05.patch, > HIVE-19711.06.patch, HIVE-19711.07.patch, HIVE-19711.08.patch > > > HiveSchemaTool is an 1500 lines long class trying to do everything It shold > be cut into multiple classes doing smaller components. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)