[ https://issues.apache.org/jira/browse/HIVE-18929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530230#comment-16530230 ]
Aihua Xu commented on HIVE-18929: --------------------------------- I don't see this method is used anywhere in Hive either. Looks good to me to clean it up. +1. > The method humanReadableInt in HiveStringUtils.java has a race condition. > ------------------------------------------------------------------------- > > Key: HIVE-18929 > URL: https://issues.apache.org/jira/browse/HIVE-18929 > Project: Hive > Issue Type: Bug > Components: API > Affects Versions: 2.3.2 > Reporter: Chaiyong Ragkhitwetsagul > Assignee: Andrew Sherman > Priority: Minor > Attachments: HIVE-18929.1.patch > > > I found that the {{humanReadableInt(long number)}} method in the > hive/common/src/java/org/apache/hive/common/util/HiveStringUtils.java file > contains code which has a race condition as shown in Hadoop (issue tracking > ID HADOOP-9252: https://issues.apache.org/jira/browse/HADOOP-9252). The fix > can also be seen in the Hadoop code base. > I couldn't find a call to the method anywhere else in the code. But it might > be worth to fix. -- This message was sent by Atlassian JIRA (v7.6.3#76005)