[ 
https://issues.apache.org/jira/browse/HIVE-19834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539106#comment-16539106
 ] 

BELUGA BEHR edited comment on HIVE-19834 at 7/10/18 7:09 PM:
-------------------------------------------------------------

OK, since this object is not re-usable, I suggest that we instead use the 
{{Closeable}} interface and use a paradigm that people are more familiar with.

I also wipe out the data structures of interest by simply writing 'null' values 
to the variable to allow the data structure to be GC'ed ASAP (for example, 
while the scratch directories are being removed).

In this patch, I also removed the Hadoop StringUtil 'strinfigyException' calls. 
 It's not needed with slf4j.


was (Author: belugabehr):
OK, since this object is not re-usable, I suggest that we instead use the 
{{Closeable}} interface and use a paradigm that people are more familiar with.

I also wipe out the data structures of interest by simply writing 'null' values 
to the variable to allow the data structure to be GC'ed ASAP (for example, 
while the scratch directories are being removed).

> Clear Context Map of Paths to ContentSummary
> --------------------------------------------
>
>                 Key: HIVE-19834
>                 URL: https://issues.apache.org/jira/browse/HIVE-19834
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>    Affects Versions: 3.0.0, 2.3.2, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HIVE-19834.1.patch, HIVE-19834.2.patch
>
>
> The {{Context}} class has a {{clear}} method which is called.  During the 
> method, various files are deleted and in-memory maps are cleared.  I would 
> like to propose that we clear out an additional in-memory map structure that 
> may contain a lot of data so that it can be GC'ed asap. This map contains 
> mapping of "File Path"->"Content Summary".  For a query with a large file 
> set, this can be quite large.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to