[
https://issues.apache.org/jira/browse/HIVE-20006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541402#comment-16541402
]
Hive QA commented on HIVE-20006:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
32s{color} | {color:blue} common in master has 64 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
52s{color} | {color:blue} standalone-metastore in master has 217 extant
Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
45s{color} | {color:blue} ql in master has 2287 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
14s{color} | {color:red} common: The patch generated 1 new + 422 unchanged - 5
fixed = 423 total (was 427) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
36s{color} | {color:red} standalone-metastore: The patch generated 9 new + 1959
unchanged - 13 fixed = 1968 total (was 1972) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
38s{color} | {color:red} ql: The patch generated 4 new + 380 unchanged - 4
fixed = 384 total (was 384) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
20s{color} | {color:red} root: The patch generated 14 new + 2761 unchanged - 22
fixed = 2775 total (was 2783) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 6 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
3s{color} | {color:red} standalone-metastore generated 3 new + 215 unchanged -
2 fixed = 218 total (was 217) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
52s{color} | {color:red} ql generated 1 new + 2286 unchanged - 1 fixed = 2287
total (was 2287) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} standalone-metastore generated 0 new + 53 unchanged
- 1 fixed = 53 total (was 54) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} ql in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
39s{color} | {color:green} root generated 0 new + 370 unchanged - 1 fixed = 370
total (was 371) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 68m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore |
| |
org.apache.hadoop.hive.metastore.txn.TxnHandler.lockMaterializationRebuild(String,
String, long) passes a nonconstant String to an execute or addBatch method on
an SQL statement At TxnHandler.java:nonconstant String to an execute or
addBatch method on an SQL statement At TxnHandler.java:[line 1785] |
| |
org.apache.hadoop.hive.metastore.txn.TxnHandler.cleanupMaterializationRebuildLocks(ValidTxnList,
long) passes a nonconstant String to an execute or addBatch method on an SQL
statement At TxnHandler.java:String to an execute or addBatch method on an SQL
statement At TxnHandler.java:[line 1883] |
| |
org.apache.hadoop.hive.metastore.txn.TxnHandler.getMaterializationInvalidationInfo(CreationMetadata,
String) passes a nonconstant String to an execute or addBatch method on an SQL
statement At TxnHandler.java:String to an execute or addBatch method on an SQL
statement At TxnHandler.java:[line 1736] |
| FindBugs | module:ql |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hive.ql.metadata.Hive.getValidMaterializedViews(String, List,
List, boolean) At Hive.java:is not thrown in
org.apache.hadoop.hive.ql.metadata.Hive.getValidMaterializedViews(String, List,
List, boolean) At Hive.java:[line 1528] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12548/dev-support/hive-personality.sh
|
| git revision | master / 5ade740 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12548/yetus/diff-checkstyle-common.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12548/yetus/diff-checkstyle-standalone-metastore.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12548/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12548/yetus/diff-checkstyle-root.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12548/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12548/yetus/new-findbugs-standalone-metastore.html
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12548/yetus/new-findbugs-ql.html
|
| modules | C: common standalone-metastore ql . U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12548/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Make materializations invalidation cache work with multiple active remote
> metastores
> ------------------------------------------------------------------------------------
>
> Key: HIVE-20006
> URL: https://issues.apache.org/jira/browse/HIVE-20006
> Project: Hive
> Issue Type: Improvement
> Components: Materialized views
> Affects Versions: 3.0.0
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Critical
> Attachments: HIVE-19027.01.patch, HIVE-19027.02.patch,
> HIVE-19027.03.patch, HIVE-19027.04.patch, HIVE-20006.01.patch,
> HIVE-20006.02.patch, HIVE-20006.03.patch, HIVE-20006.04.patch,
> HIVE-20006.05.patch, HIVE-20006.patch
>
>
> The main points:
> - Only MVs stored in transactional tables can have a time window value of 0.
> Those are the only MVs that can be guaranteed to not be outdated when a query
> is executed, if we use custom storage handlers to store the materialized
> view, we cannot make any promises.
> - For MVs that +cannot be outdated+, we do not check the metastore. Instead,
> comparison is based on valid write id lists.
> - For MVs that +can be outdated+, we still rely on the invalidation cache.
> ** The window for valid outdated MVs can be specified in intervals of 1
> minute (less than that, it is difficult to have any guarantees about whether
> the MV is actually outdated by less than a minute or not).
> ** The async loading is done every interval / 2 (or probably better, we can
> make it configurable).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
