[ 
https://issues.apache.org/jira/browse/HIVE-19820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541992#comment-16541992
 ] 

Hive QA commented on HIVE-19820:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12931270/branch-19820.02.nogen.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/12558/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12558/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12558/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-07-12 17:25:19.649
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-12558/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-07-12 17:25:19.652
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 5ade740 HIVE-20088: Beeline config location path is assembled 
incorrectly (Denes Bodo via Zoltan Haindrich)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 5ade740 HIVE-20088: Beeline config location path is assembled 
incorrectly (Denes Bodo via Zoltan Haindrich)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-07-12 17:25:21.085
+ rm -rf ../yetus_PreCommit-HIVE-Build-12558
+ mkdir ../yetus_PreCommit-HIVE-Build-12558
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-12558
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-12558/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:1648
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:633
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java' 
with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java:405
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java' cleanly.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java:157
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java'
 cleanly.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:296
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:4895
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:1901
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1448
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/main/thrift/hive_metastore.thrift:571
Falling back to three-way merge...
Applied patch to 'standalone-metastore/src/main/thrift/hive_metastore.thrift' 
with conflicts.
error: patch failed: 
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:1635
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveAlterHandler.java:60
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveAlterHandler.java'
 with conflicts.
Going to apply patch with: git apply -p0
/data/hiveptest/working/scratch/build.patch:1698: trailing whitespace.
                  sort order: 
/data/hiveptest/working/scratch/build.patch:1851: trailing whitespace.
                  sort order: 
/data/hiveptest/working/scratch/build.patch:1946: trailing whitespace.
                  sort order: 
/data/hiveptest/working/scratch/build.patch:2049: trailing whitespace.
                  sort order: 
/data/hiveptest/working/scratch/build.patch:2306: trailing whitespace.
                  sort order: 
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:1648
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java' with 
conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:633
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java' 
with conflicts.
error: patch failed: 
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java:405
Falling back to three-way merge...
Applied patch to 
'ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUpdaterThread.java' cleanly.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java:157
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java'
 cleanly.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:296
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:4895
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:1901
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1448
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/main/thrift/hive_metastore.thrift:571
Falling back to three-way merge...
Applied patch to 'standalone-metastore/src/main/thrift/hive_metastore.thrift' 
with conflicts.
error: patch failed: 
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:1635
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java'
 with conflicts.
error: patch failed: 
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveAlterHandler.java:60
Falling back to three-way merge...
Applied patch to 
'standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveAlterHandler.java'
 with conflicts.
U ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
U ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
U 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
U 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
U 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
U 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
U standalone-metastore/src/main/thrift/hive_metastore.thrift
U 
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
U 
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveAlterHandler.java
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-12558
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12931270 - PreCommit-HIVE-Build

> add ACID stats support to background stats updater and fix bunch of edge 
> cases found in SU tests
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-19820
>                 URL: https://issues.apache.org/jira/browse/HIVE-19820
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Major
>         Attachments: HIVE-19820.01-master-txnstats.patch, 
> HIVE-19820.01.patch, HIVE-19820.02-master-txnstats.patch, 
> HIVE-19820.03-master-txnstats.patch, HIVE-19820.04-master-txnstats.patch, 
> HIVE-19820.patch, branch-19820.02.nogen.patch, branch-19820.nogen.patch, 
> branch-19820.nogen.patch
>
>
> Follow-up from HIVE-19418.
> Right now it checks whether stats are valid in an old-fashioned way... and 
> also gets ACID state, and discards it without using.
> When ACID stats are implemented, ACID state needs to be used to do 
> version-aware valid stats checks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to