[ 
https://issues.apache.org/jira/browse/HIVE-20159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

BELUGA BEHR updated HIVE-20159:
-------------------------------
    Description: 
https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java#L121

{code}
    } catch (IOException e) {
      e.printStackTrace();
    }
{code}

Introduce an SLF4J logger to this class and print a WARN level log message if 
the {{IOException}} from {{Utilities.listStatusIfExists}} is generated.  I 
suggest WARN because the entire operation doesn't fail if this error happens.  
It continues on its way with the data that it was able to collect.  I'm not 
sure if this is the intended behavior, but for now, a helpful warning message 
in the logging would be better.

  was:
https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java#L121

{code}
    } catch (IOException e) {
      e.printStackTrace();
    }
{code}

Introduce an SLF4J logger to this class and print a WARN level log message if 
the {{IOException}} from {{Utilities.listStatusIfExists}} is generated.  I 
suggest WARN because the entire operation doesn't fail if this error happens.  
It continues on its way with the data that it was able to collect.  I'm not 
sure if this is the intended behavior, but for now, an error message in the 
logging would be better.


> Do Not Print StackTraces to STDERR in ConditionalResolverSkewJoin
> -----------------------------------------------------------------
>
>                 Key: HIVE-20159
>                 URL: https://issues.apache.org/jira/browse/HIVE-20159
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Planning
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Priority: Minor
>              Labels: newbie, noob
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java#L121
> {code}
>     } catch (IOException e) {
>       e.printStackTrace();
>     }
> {code}
> Introduce an SLF4J logger to this class and print a WARN level log message if 
> the {{IOException}} from {{Utilities.listStatusIfExists}} is generated.  I 
> suggest WARN because the entire operation doesn't fail if this error happens. 
>  It continues on its way with the data that it was able to collect.  I'm not 
> sure if this is the intended behavior, but for now, a helpful warning message 
> in the logging would be better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to