[ https://issues.apache.org/jira/browse/HIVE-17593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543701#comment-16543701 ]
Hive QA commented on HIVE-17593: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12931423/HIVE-17593.4.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14650 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorStringExpressions.testStringLength (batchId=300) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12591/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12591/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12591/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12931423 - PreCommit-HIVE-Build > DataWritableWriter strip spaces for CHAR type before writing, but predicate > generator doesn't do same thing. > ------------------------------------------------------------------------------------------------------------ > > Key: HIVE-17593 > URL: https://issues.apache.org/jira/browse/HIVE-17593 > Project: Hive > Issue Type: Bug > Affects Versions: 2.3.0, 3.0.0 > Reporter: Junjie Chen > Assignee: Junjie Chen > Priority: Major > Labels: pull-request-available > Attachments: HIVE-17593.2.patch, HIVE-17593.3.patch, > HIVE-17593.4.patch, HIVE-17593.patch > > > DataWritableWriter strip spaces for CHAR type before writing. While when > generating predicate, it does NOT do same striping which should cause data > missing! > In current version, it doesn't cause data missing since predicate is not well > push down to parquet due to HIVE-17261. > Please see ConvertAstTosearchArg.java, getTypes treats CHAR and STRING as > same which will build a predicate with tail spaces. -- This message was sent by Atlassian JIRA (v7.6.3#76005)