[ https://issues.apache.org/jira/browse/HIVE-20174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544951#comment-16544951 ]
Hive QA commented on HIVE-20174: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 15s{color} | {color:blue} ql in master has 2291 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 0s{color} | {color:red} ql: The patch generated 216 new + 2123 unchanged - 83 fixed = 2339 total (was 2206) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 15s{color} | {color:red} ql generated 1 new + 2272 unchanged - 19 fixed = 2273 total (was 2291) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 18s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Redundant nullcheck of inputExpression, which is known to be non-null in org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer.getVectorAggregationDesc(String, List, GenericUDAFEvaluator, TypeInfo, GenericUDAFEvaluator$Mode, VectorizationContext) Redundant null check at Vectorizer.java:is known to be non-null in org.apache.hadoop.hive.ql.optimizer.physical.Vectorizer.getVectorAggregationDesc(String, List, GenericUDAFEvaluator, TypeInfo, GenericUDAFEvaluator$Mode, VectorizationContext) Redundant null check at Vectorizer.java:[line 4273] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12630/dev-support/hive-personality.sh | | git revision | master / 64ceb7b | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12630/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12630/yetus/new-findbugs-ql.html | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12630/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Vectorization: Fix NULL / Wrong Results issues in GROUP BY Aggregation > Functions > -------------------------------------------------------------------------------- > > Key: HIVE-20174 > URL: https://issues.apache.org/jira/browse/HIVE-20174 > Project: Hive > Issue Type: Bug > Components: Hive > Reporter: Matt McCline > Assignee: Matt McCline > Priority: Critical > Attachments: HIVE-20174.01.patch, HIVE-20174.02.patch, > HIVE-20174.03.patch, HIVE-20174.04.patch > > > Write new UT tests that use random data and intentional isRepeating batches > to checks for NULL and Wrong Results for vectorized aggregation functions. > > BUGs found: > 1) AVG/VARIANCE (family) in PARTIAL1 mode was returning NULL instead of count > = 0, sum = 0 (All data types). For AVG DECIMAL, only return NULL if there > was an overflow. > 2) AVG/MIN/MAX was not detecting repeated NULL correctly for the TIMESTAMP, > INTERVAL_DAY_TIME, and String Family. Eliminated redundant code. > 3) Fix incorrect calculation for VARIANCE (family) in PARTIAL2 and FINAL > modes (HIVE-18758). > 4) Fix row-mode AVG DECIMAL to enforce output type precision and scale in > COMPLETE and FINAL modes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)