[ https://issues.apache.org/jira/browse/HIVE-20168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543294#comment-16543294 ]
BELUGA BEHR edited comment on HIVE-20168 at 7/23/18 1:57 PM: ------------------------------------------------------------- Actually... don't remove anything... just change the guards to check for INFO level logging so that it matches the {{MapOperator}} implementation. Though you should do: {code} if (LOG.isInfoEnabled()) { LOG.info(toString() + ": records written - " + numRows); } // --------------- LOG.info("{} records written - {}", this, numRows); {code} was (Author: belugabehr): Actually... don't remove anything... just change the guards to check for INFO level logging so that it matches the {{MapOperator}} implementation. Though you should do: {code} if (LOG.isTraceEnabled()) { LOG.info(toString() + ": records written - " + numRows); } // --------------- LOG.info("{} records written - {}", this, numRows); {code} > ReduceSinkOperator Logging Hidden > --------------------------------- > > Key: HIVE-20168 > URL: https://issues.apache.org/jira/browse/HIVE-20168 > Project: Hive > Issue Type: Bug > Components: Operators > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Assignee: Bharathkrishna Guruvayoor Murali > Priority: Minor > Labels: newbie, noob > > [https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java] > > {code:java} > if (LOG.isTraceEnabled()) { > if (numRows == cntr) { > cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows; > if (cntr < 0 || numRows < 0) { > cntr = 0; > numRows = 1; > } > LOG.info(toString() + ": records written - " + numRows); > } > } > ... > if (LOG.isTraceEnabled()) { > LOG.info(toString() + ": records written - " + numRows); > } > {code} > There are logging guards here checking for TRACE level debugging but the > logging is actually INFO. This is important logging for detecting data skew. > Please change guards to check for INFO... or I would prefer that the guards > are removed altogether since it's very rare that a service is running with > only WARN level logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)