[ https://issues.apache.org/jira/browse/HIVE-19891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553364#comment-16553364 ]
Hive QA commented on HIVE-19891: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 8s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 1s{color} | {color:blue} ql in master has 2280 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 42s{color} | {color:red} ql: The patch generated 3 new + 497 unchanged - 0 fixed = 500 total (was 497) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 4s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12802/dev-support/hive-personality.sh | | git revision | master / 5e7aa09 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12802/yetus/diff-checkstyle-ql.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12802/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > inserting into external tables with custom partition directories may cause > data loss > ------------------------------------------------------------------------------------ > > Key: HIVE-19891 > URL: https://issues.apache.org/jira/browse/HIVE-19891 > Project: Hive > Issue Type: Bug > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Priority: Major > Attachments: HIVE-19891.01.patch, HIVE-19891.02.patch, > HIVE-19891.03.patch, HIVE-19891.04.patch, HIVE-19891.05.patch, > HIVE-19891.06.patch, HIVE-19891.07.patch, HIVE-19891.patch > > > tbl1 is just used as a prop to create data, could be an existing directory > for an external table. > Due to weird behavior of LoadTableDesc (some ancient code for overriding old > partition path), custom partition path is overwritten after the query and the > data in it ceases being a part of the table (can be seen in desc formatted > output with masking commented out in QTestUtil) > This affects branch-1 too, so it's pretty old. > {noformat}drop table tbl1; > CREATE TABLE tbl1 (index int, value int ) PARTITIONED BY ( created_date > string ); > insert into tbl1 partition(created_date='2018-02-01') VALUES (2, 2); > CREATE external TABLE tbl2 (index int, value int ) PARTITIONED BY ( > created_date string ); > ALTER TABLE tbl2 ADD PARTITION(created_date='2018-02-01'); > ALTER TABLE tbl2 PARTITION(created_date='2018-02-01') SET LOCATION > 'file:/Users/sergey/git/hivegit/itests/qtest/target/warehouse/tbl1/created_date=2018-02-01'; > select * from tbl2; > describe formatted tbl2 partition(created_date='2018-02-01'); > insert into tbl2 partition(created_date='2018-02-01') VALUES (1, 1); > select * from tbl2; > describe formatted tbl2 partition(created_date='2018-02-01'); > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)