[
https://issues.apache.org/jira/browse/HIVE-20162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556239#comment-16556239
]
BELUGA BEHR commented on HIVE-20162:
------------------------------------
Since this is a low-level abstract class, we probably don't want to consume the
Exception quite yet. I think we should change this to:
{code}
throw new SemanticException("Generate Map Join Task Error", e);
{code}
.. and let the parent class worry about formatting the error message.
> Do Not Print StackTraces to STDERR in AbstractJoinTaskDispatcher
> ----------------------------------------------------------------
>
> Key: HIVE-20162
> URL: https://issues.apache.org/jira/browse/HIVE-20162
> Project: Hive
> Issue Type: Improvement
> Components: Query Planning
> Affects Versions: 3.0.0, 4.0.0
> Reporter: BELUGA BEHR
> Priority: Minor
> Labels: newbie, noob
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
> {code}
> } catch (Exception e) {
> e.printStackTrace();
> throw new SemanticException("Generate Map Join Task Error: " +
> e.getMessage());
> }
> {code}
> Remove the call to {{printStackTrace}} and just throw the error. If the
> stack trace really is needed (doubtful), then pass it to the
> {{SemanticException}} constructor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
