[ https://issues.apache.org/jira/browse/HIVE-20166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562743#comment-16562743 ]
Hive QA commented on HIVE-20166: -------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 41s{color} | {color:blue} serde in master has 195 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 12m 45s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12953/dev-support/hive-personality.sh | | git revision | master / 65f02d2 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: serde U: serde | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12953/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > LazyBinaryStruct Warn Level Logging > ----------------------------------- > > Key: HIVE-20166 > URL: https://issues.apache.org/jira/browse/HIVE-20166 > Project: Hive > Issue Type: Improvement > Components: Serializers/Deserializers > Affects Versions: 3.0.0, 4.0.0 > Reporter: BELUGA BEHR > Assignee: Anurag Mantripragada > Priority: Minor > Labels: newbie, noob > Attachments: HIVE-20166.1.patch > > > https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java#L177-L180 > {code} > // Extra bytes at the end? > if (!extraFieldWarned && lastFieldByteEnd < structByteEnd) { > extraFieldWarned = true; > LOG.warn("Extra bytes detected at the end of the row! " + > "Last field end " + lastFieldByteEnd + " and serialize buffer end > " + structByteEnd + ". " + > "Ignoring similar problems."); > } > // Missing fields? > if (!missingFieldWarned && lastFieldByteEnd > structByteEnd) { > missingFieldWarned = true; > LOG.info("Missing fields! Expected " + fields.length + " fields but " + > "only got " + fieldId + "! " + > "Last field end " + lastFieldByteEnd + " and serialize buffer end " > + structByteEnd + ". " + > "Ignoring similar problems."); > } > {code} > The first log statement is a 'warn' level logging, the second is an 'info' > level logging. Please change the second log to also be a 'warn'. This seems > like it could be a problem that the user would like to know about. -- This message was sent by Atlassian JIRA (v7.6.3#76005)