[ https://issues.apache.org/jira/browse/HIVE-20277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568878#comment-16568878 ]
Hive QA commented on HIVE-20277: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 33s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 14s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 48s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 17s{color} | {color:blue} ql in master has 2301 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 7s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 48s{color} | {color:red} ql: The patch generated 7 new + 382 unchanged - 3 fixed = 389 total (was 385) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 1s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13031/dev-support/hive-personality.sh | | git revision | master / a3cd496 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13031/yetus/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13031/yetus/whitespace-eol.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13031/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Vectorization: Case expressions that return BOOLEAN are not supported for > FILTER > -------------------------------------------------------------------------------- > > Key: HIVE-20277 > URL: https://issues.apache.org/jira/browse/HIVE-20277 > Project: Hive > Issue Type: Bug > Components: Vectorization > Affects Versions: 4.0.0 > Reporter: Gopal V > Assignee: Matt McCline > Priority: Major > Attachments: HIVE-20277.02.patch, HIVE-20277.WIP.01.patch > > > In cases like Query89, the vertex with the filter is not vectorized. > {code} > Filter Operator > predicate: CASE WHEN ((avg_window_0 <> 0.0D)) THEN > (((abs((_col6 - avg_window_0)) / avg_window_0) > 0.1D)) ELSE (null) END > (type: boolean) > {code} > {code} > Reducer 3 > Execution mode: llap > Reduce Vectorization: > enabled: true > enableConditionsMet: hive.vectorized.execution.reduce.enabled > IS true, hive.execution.engine tez IN [tez, spark] IS true > notVectorizedReason: FILTER operator: Unexpected hive type > name void > vectorized: false > {code} > The query specifically has > {code} > where case when (avg_monthly_sales <> 0) then (abs(sum_sales - > avg_monthly_sales) / avg_monthly_sales) else null end > 0.1 > {code} > while rewriting it to > {code} > where case when (avg_monthly_sales <> 0) then (abs(sum_sales - > avg_monthly_sales) / avg_monthly_sales) > 0.1 else false end > {code} > does vectorize into > {code} > Filter Operator > Filter Vectorization: > className: VectorFilterOperator > native: true > predicateExpression: SelectColumnIsTrue(col > 12:boolean)(children: VectorUDFAdaptor(CASE WHEN ((avg_window_0 <> 0.0D)) > THEN (((abs((_col6 - avg_window_0)) / avg_window_0) > 0.1D)) ELSE (false) > END)(children: DoubleColNotEqualDoubleScalar(col 7:double, val 0.0) -> > 8:boolean, DoubleColGreaterDoubleScalar(col 9:double, val 0.1)(children: > DoubleColDivideDoubleColumn(col 10:double, col 7:double)(children: > FuncAbsDoubleToDouble(col 9:double)(children: > DoubleColSubtractDoubleColumn(col 6:double, col 7:double) -> 9:double) -> > 10:double) -> 9:double) -> 11:boolean) -> 12:boolean) > predicate: CASE WHEN ((avg_window_0 <> 0.0D)) THEN > (((abs((_col6 - avg_window_0)) / avg_window_0) > 0.1D)) ELSE (false) END > (type: boolean) > Statistics: Num rows: 11 Data size: 5291 Basic stats: > COMPLETE Column stats: COMPLETE > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)