[ https://issues.apache.org/jira/browse/HIVE-20393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582079#comment-16582079 ]
Hive QA commented on HIVE-20393: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12935765/HIVE-20393.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14878 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13258/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13258/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13258/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12935765 - PreCommit-HIVE-Build > Semijoin Reduction : markSemiJoinForDPP behaves inconsistently > -------------------------------------------------------------- > > Key: HIVE-20393 > URL: https://issues.apache.org/jira/browse/HIVE-20393 > Project: Hive > Issue Type: Bug > Reporter: Deepak Jaiswal > Assignee: Deepak Jaiswal > Priority: Major > Attachments: HIVE-20393.1.patch, HIVE-20393.2.patch > > > markSemiJoinForDPP has multiple issues, > > * Uses map tsOps which is wrong as it disallows going thru same TS which may > have filters from more than 1 semijoin edges. This results in inconsistent > plans for same query as semijoin edges may be processed in different order > each time. > * Uses getColumnExpr() which is not as robust as extractColumn() thus > resulting in NPEs. > * The logic to mark an edge useful when NPE is hit may end up having bad > edge. > cc [~gopalv] -- This message was sent by Atlassian JIRA (v7.6.3#76005)