[
https://issues.apache.org/jira/browse/HIVE-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590075#comment-16590075
]
Mass Dosage commented on HIVE-18767:
------------------------------------
[~pvary] I have added patches as follows:
HIVE-18767-branch-2.3.patch -> Ieft that as is, the code appears to be present
in the branch so I'm not sure how it didn't make it into 2.3.3 but hopefully
having it here will mean it would make it into 2.3.4 (if this is ever released)
HIVE-18767-branch-2.patch -> I have added this, it's pretty much the same as
above, just on a different branch.
HIVE-18767-branch-3.1.patch -> added, pretty much the same, only difference is
that the classes have moved to a different module
HIVE-18767/HIVE-18767-branch-3.patch -> added, pretty much the same as above
HIVE-18767.5.patch -> added, this is for master. The code has moved to a new
class, the change is the same here. The tests however were quite different as
someone had actually added a test for the method. I made quite a few changes to
the test - I renamed the test class to match the fact that the class under test
has also changed name; I removed the static imports of the methods under test
as some tests were using the fully qualified class name and some weren't - I
prefer consistency and also think using the full class name is more clear to
show where the test methods are; finally I replaced the new test with the set
of tests that I added in my previous patches as I think it's clearer to have a
test for each condition rather than munging them all into one test and these
tests run really quickly.
Could you please help with getting these merged where appropriate? If there is
anything else I can to do ensure these changes actually go into a future
release that would be great as we'd really like this change in a production
version so we can remove workarounds on our side.
> Some alterPartitions invocations throw 'NumberFormatException: null'
> --------------------------------------------------------------------
>
> Key: HIVE-18767
> URL: https://issues.apache.org/jira/browse/HIVE-18767
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 2.3.3, 3.1.0, 4.0.0, 3.2.0
> Reporter: Yuming Wang
> Assignee: Mass Dosage
> Priority: Major
> Fix For: 2.3.3, 3.1.0, 4.0.0, 3.2.0
>
> Attachments: HIVE-18767-branch-2.3.patch, HIVE-18767-branch-2.patch,
> HIVE-18767-branch-3.1.patch, HIVE-18767-branch-3.patch, HIVE-18767.1.patch,
> HIVE-18767.2.patch, HIVE-18767.3.patch, HIVE-18767.4.patch, HIVE-18767.5.patch
>
>
> Error messages:
> {noformat}
> [info] Cause: java.lang.NumberFormatException: null
> [info] at java.lang.Long.parseLong(Long.java:552)
> [info] at java.lang.Long.parseLong(Long.java:631)
> [info] at
> org.apache.hadoop.hive.metastore.MetaStoreUtils.isFastStatsSame(MetaStoreUtils.java:315)
> [info] at
> org.apache.hadoop.hive.metastore.HiveAlterHandler.alterPartitions(HiveAlterHandler.java:605)
> [info] at
> org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.alter_partitions_with_environment_context(HiveMetaStore.java:3837)
> [info] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [info] at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [info] at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [info] at java.lang.reflect.Method.invoke(Method.java:498)
> [info] at
> org.apache.hadoop.hive.metastore.RetryingHMSHandler.invokeInternal(RetryingHMSHandler.java:148)
> [info] at
> org.apache.hadoop.hive.metastore.RetryingHMSHandler.invoke(RetryingHMSHandler.java:107)
> [info] at
> com.sun.proxy.$Proxy23.alter_partitions_with_environment_context(Unknown
> Source)
> [info] at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.alter_partitions(HiveMetaStoreClient.java:1527)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
