[ 
https://issues.apache.org/jira/browse/HIVE-20394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593349#comment-16593349
 ] 

Zoltan Haindrich commented on HIVE-20394:
-----------------------------------------

Thank you [~pvary] for pinging me! :)
please don't do this in "setup()":

{code}
-      qt.newSession();
+      qt.clearTestSideEffects();
{code}

this will restore the old erratic behaviour which is: the "next" test will try 
to cleanup after the previous one; which would be a step backward...
{{qt.clearTestSideEffects}} should belong to the after ...if you would like to 
have a way to leave the tables/databases behind; please add an option or 
something which prevents cleanup...

Maybe I'm just skeptical; but I don't believe that adding a builder would make 
qtestutil any better - I think instead of trying to fix qtestutil; we should 
roll some new stuff...but it's fine by me as long as it works...
but if you are introducing it...you might want to consider using it to hide 
away configuration decisions..like: "if (testArgs.getFsType() != null)"

> Optimized & cleaned up HBaseQTest runner
> ----------------------------------------
>
>                 Key: HIVE-20394
>                 URL: https://issues.apache.org/jira/browse/HIVE-20394
>             Project: Hive
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 4.0.0
>            Reporter: denys kuzmenko
>            Assignee: denys kuzmenko
>            Priority: Major
>         Attachments: HIVE-20394.1.patch, HIVE-20394.2.patch, 
> HIVE-20394.3.patch, HIVE-20394.4.patch, HIVE-20394.5.patch, 
> HIVE-20394.6.patch, HIVE-20394.7.patch
>
>
> # Set proper cluster destroy order
>  # Propagated proper HBaseTestContext
>  # Ported downstream fixes (CDH-63695)
>  # General clean up



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to