[ 
https://issues.apache.org/jira/browse/HIVE-20365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594436#comment-16594436
 ] 

Vihang Karajgaonkar commented on HIVE-20365:
--------------------------------------------

[~asherman] mentioned that this might break wire compatibility. I tried keeping 
it at -1 but thrift doesn't like non-positive numbers for fieldIds. May be we 
can just fix it in 4.0 branch. [~alangates] I think this was introduced in 
HIVE-17990? Do you think its okay to change it now to get rid of the warnings? 
or should we just limit the change to 4.0?

> Fix warnings when regenerating thrift code
> ------------------------------------------
>
>                 Key: HIVE-20365
>                 URL: https://issues.apache.org/jira/browse/HIVE-20365
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Major
>         Attachments: HIVE-20365.01.patch
>
>
> When you build thrift code you can see thrift warning like below.
> [exec] 
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167]
>  No field key specified for rqst, resulting protocol may have conflicts or 
> not be backwards compatible!
>  [exec]
>  [exec] 
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235]
>  No field key specified for o2, resulting protocol may have conflicts or not 
> be backwards compatible!
>  [exec]
>  [exec] 
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2167]
>  No field key specified for rqst, resulting protocol may have conflicts or 
> not be backwards compatible!
>  [exec]
>  [exec] 
> [WARNING:hive/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:2235]
>  No field key specified for o2, resulting protocol may have conflicts or not 
> be backwards compatible!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to