[ https://issues.apache.org/jira/browse/HIVE-20483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601779#comment-16601779 ]
Hive QA commented on HIVE-20483: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 43s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 6s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 28s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 26s{color} | {color:blue} standalone-metastore/metastore-common in master has 9 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 31s{color} | {color:blue} beeline in master has 53 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 27s{color} | {color:blue} hcatalog/hcatalog-pig-adapter in master has 2 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 1s{color} | {color:blue} ql in master has 2310 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 14s{color} | {color:red} metastore-server in master failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 47s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 26s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 4s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 50s{color} | {color:red} standalone-metastore/metastore-common generated 23 new + 5 unchanged - 4 fixed = 28 total (was 9) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 16s{color} | {color:red} metastore-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 55s{color} | {color:red} standalone-metastore_metastore-common generated 15 new + 4 unchanged - 1 fixed = 19 total (was 5) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} metastore in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} beeline in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s{color} | {color:green} hcatalog-pig-adapter in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} ql in the patch passed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} standalone-metastore_metastore-server generated 0 new + 49 unchanged - 12 fixed = 49 total (was 61) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 46m 26s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:standalone-metastore/metastore-common | | | Redundant nullcheck of new_parts, which is known to be non-null in org.apache.hadoop.hive.metastore.HiveMetaStoreClient.add_partitions(List) Redundant null check at HiveMetaStoreClient.java:is known to be non-null in org.apache.hadoop.hive.metastore.HiveMetaStoreClient.add_partitions(List) Redundant null check at HiveMetaStoreClient.java:[line 749] | | | Nullcheck of rsp at line 3012 of value previously dereferenced in org.apache.hadoop.hive.metastore.HiveMetaStoreClient.getNextNotification(long, int, IMetaStoreClient$NotificationFilter) At HiveMetaStoreClient.java:3012 of value previously dereferenced in org.apache.hadoop.hive.metastore.HiveMetaStoreClient.getNextNotification(long, int, IMetaStoreClient$NotificationFilter) At HiveMetaStoreClient.java:[line 3012] | | | org.apache.hadoop.hive.metastore.HiveMetaStoreClient.getTypeAll(String) makes inefficient use of keySet iterator instead of entrySet iterator At HiveMetaStoreClient.java:keySet iterator instead of entrySet iterator At HiveMetaStoreClient.java:[line 1574] | | | Found reliance on default encoding in org.apache.hadoop.hive.metastore.ReplChangeManager.recycle(Path, ReplChangeManager$RecycleType, boolean):in org.apache.hadoop.hive.metastore.ReplChangeManager.recycle(Path, ReplChangeManager$RecycleType, boolean): String.getBytes() At ReplChangeManager.java:[line 246] | | | org.apache.hadoop.hive.metastore.Warehouse.makePartName(List, List, String) concatenates strings using + in a loop At Warehouse.java:using + in a loop At Warehouse.java:[line 725] | | | Possible doublecheck on org.apache.hadoop.hive.metastore.conf.MetastoreConf.keyToVars in org.apache.hadoop.hive.metastore.conf.MetastoreConf.get(Configuration, String) At MetastoreConf.java:org.apache.hadoop.hive.metastore.conf.MetastoreConf.get(Configuration, String) At MetastoreConf.java:[lines 1594-1596] | | | Boxing/unboxing to parse a primitive org.apache.hadoop.hive.metastore.conf.MetastoreConf.getLongVar(Configuration, MetastoreConf$ConfVars) At MetastoreConf.java:org.apache.hadoop.hive.metastore.conf.MetastoreConf.getLongVar(Configuration, MetastoreConf$ConfVars) At MetastoreConf.java:[line 1382] | | | Incorrect lazy initialization of static field org.apache.hadoop.hive.metastore.conf.MetastoreConf.hiveSiteURL in org.apache.hadoop.hive.metastore.conf.MetastoreConf.newMetastoreConf(Configuration) At MetastoreConf.java:field org.apache.hadoop.hive.metastore.conf.MetastoreConf.hiveSiteURL in org.apache.hadoop.hive.metastore.conf.MetastoreConf.newMetastoreConf(Configuration) At MetastoreConf.java:[lines 1184-1191] | | | org.apache.hadoop.hive.metastore.conf.MetastoreConf.metaVars is a mutable array At MetastoreConf.java: At MetastoreConf.java:[line 143] | | | Null passed for non-null parameter of new java.io.File(URI) in org.apache.hadoop.hive.metastore.conf.MetastoreConf.findConfigFile(ClassLoader, String) Method invoked at MetastoreConf.java:of new java.io.File(URI) in org.apache.hadoop.hive.metastore.conf.MetastoreConf.findConfigFile(ClassLoader, String) Method invoked at MetastoreConf.java:[line 1267] | | | Null passed for non-null parameter of timeAbbreviationFor(TimeUnit) in org.apache.hadoop.hive.metastore.conf.MetastoreConf.getAsString(Configuration, MetastoreConf$ConfVars) Method invoked at MetastoreConf.java:of timeAbbreviationFor(TimeUnit) in org.apache.hadoop.hive.metastore.conf.MetastoreConf.getAsString(Configuration, MetastoreConf$ConfVars) Method invoked at MetastoreConf.java:[line 1638] | | | Rough value of 3.141592654 found:MetastoreConf.java:[line 971] At MetastoreConf.java:[line 971] | | | org.apache.hadoop.hive.metastore.partition.spec.PartitionSpecProxy$SimplePartitionWrapperIterator.next() can't throw NoSuchElementException At PartitionSpecProxy.java:At PartitionSpecProxy.java:[line 216] | | | Possible doublecheck on org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge.self in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge.getBridge() At HadoopThriftAuthBridge.java:org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge.getBridge() At HadoopThriftAuthBridge.java:[lines 80-82] | | | Found reliance on default encoding in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Client$SaslClientCallbackHandler.encodeIdentifier(byte[]):in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Client$SaslClientCallbackHandler.encodeIdentifier(byte[]): new String(byte[]) At HadoopThriftAuthBridge.java:[line 307] | | | Found reliance on default encoding in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Client$SaslClientCallbackHandler.encodePassword(byte[]):in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Client$SaslClientCallbackHandler.encodePassword(byte[]): new String(byte[]) At HadoopThriftAuthBridge.java:[line 311] | | | Found reliance on default encoding in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Server$SaslDigestCallbackHandler.encodePassword(byte[]):in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Server$SaslDigestCallbackHandler.encodePassword(byte[]): new String(byte[]) At HadoopThriftAuthBridge.java:[line 515] | | | Should org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge$Server$TUGIAssumingProcessor be a _static_ inner class? At HadoopThriftAuthBridge.java:inner class? At HadoopThriftAuthBridge.java:[lines 583-664] | | | Exception is caught when Exception is not thrown in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge23.<static initializer for HadoopThriftAuthBridge23>() At HadoopThriftAuthBridge23.java:is not thrown in org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge23.<static initializer for HadoopThriftAuthBridge23>() At HadoopThriftAuthBridge23.java:[line 57] | | | input must be non-null but is marked as nullable At HdfsUtils.java:is marked as nullable At HdfsUtils.java:[lines 365-368] | | | org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.addToClassPath(ClassLoader, String[]) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block At MetaStoreUtils.java:classloader, which should be performed within a doPrivileged block At MetaStoreUtils.java:[line 402] | | | Public static org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.parseDbName(String, Configuration) may expose internal representation by returning MetaStoreUtils.nullCatalogAndDatabase At MetaStoreUtils.java:expose internal representation by returning MetaStoreUtils.nullCatalogAndDatabase At MetaStoreUtils.java:[line 863] | | | org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.validateName(String, Configuration) concatenates strings using + in a loop At MetaStoreUtils.java:+ in a loop At MetaStoreUtils.java:[line 194] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc xml compile findbugs checkstyle | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13563/dev-support/hive-personality.sh | | git revision | master / 8045352 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13563/yetus/branch-findbugs-standalone-metastore_metastore-server.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13563/yetus/whitespace-eol.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13563/yetus/whitespace-tabs.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13563/yetus/new-findbugs-standalone-metastore_metastore-common.html | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13563/yetus/patch-findbugs-standalone-metastore_metastore-server.txt | | javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-13563/yetus/diff-javadoc-javadoc-standalone-metastore_metastore-common.txt | | modules | C: standalone-metastore/metastore-common metastore beeline hcatalog/hcatalog-pig-adapter ql standalone-metastore/metastore-server U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13563/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Really move metastore common classes into metastore-common > ---------------------------------------------------------- > > Key: HIVE-20483 > URL: https://issues.apache.org/jira/browse/HIVE-20483 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore > Affects Versions: 3.0.1, 4.0.0 > Reporter: Alexander Kolbasov > Assignee: Alexander Kolbasov > Priority: Major > Attachments: HIVE-20483.01.patch, HIVE-20483.02.patch, > HIVE-20483.03.patch > > > HIVE-20388 patch was supposed to move a bunch of files from metastore-server > to metastore-common but for some reason it didn't happen, so now these files > should be moved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)