[ 
https://issues.apache.org/jira/browse/HIVE-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628319#comment-16628319
 ] 

Hive QA commented on HIVE-18778:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12941303/HIVE-18778.10.branch-3.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 109 failed/errored test(s), 14451 tests 
executed
*Failed tests:*
{noformat}
TestAddPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestAddPartitionsFromPartSpec - did not produce a TEST-*.xml file (likely timed 
out) (batchId=230)
TestAdminUser - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestAggregateStatsCache - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestAlterPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestAppendPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestBeeLineDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=273)
TestCachedStore - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestCatalogCaching - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestCatalogNonDefaultClient - did not produce a TEST-*.xml file (likely timed 
out) (batchId=228)
TestCatalogNonDefaultSvr - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestCatalogOldClient - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestCatalogs - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestCheckConstraint - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed 
out) (batchId=238)
TestDatabases - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestDeadline - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestDefaultConstraint - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestDropPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=273)
TestEmbeddedHiveMetaStore - did not produce a TEST-*.xml file (likely timed 
out) (batchId=231)
TestExchangePartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestFMSketchSerialization - did not produce a TEST-*.xml file (likely timed 
out) (batchId=238)
TestFilterHooks - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestForeignKey - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestFunctions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestGetPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestGetTableMeta - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestHLLNoBias - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHLLSerialization - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHdfsUtils - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestHiveAlterHandler - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestHiveMetaStoreGetMetaConf - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestHiveMetaStorePartitionSpecs - did not produce a TEST-*.xml file (likely 
timed out) (batchId=230)
TestHiveMetaStoreSchemaMethods - did not produce a TEST-*.xml file (likely 
timed out) (batchId=236)
TestHiveMetaStoreTimeout - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHiveMetaStoreTxns - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHiveMetaStoreWithEnvironmentContext - did not produce a TEST-*.xml file 
(likely timed out) (batchId=233)
TestHiveMetastoreCli - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestHyperLogLog - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHyperLogLogDense - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHyperLogLogMerge - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestHyperLogLogSparse - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestJSONMessageDeserializer - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestListPartitions - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestLockRequestBuilder - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestMarkPartition - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestMarkPartitionRemote - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestMetaStoreConnectionUrlHook - did not produce a TEST-*.xml file (likely 
timed out) (batchId=230)
TestMetaStoreEndFunctionListener - did not produce a TEST-*.xml file (likely 
timed out) (batchId=230)
TestMetaStoreEventListener - did not produce a TEST-*.xml file (likely timed 
out) (batchId=234)
TestMetaStoreEventListenerOnlyOnCommit - did not produce a TEST-*.xml file 
(likely timed out) (batchId=236)
TestMetaStoreEventListenerWithOldConf - did not produce a TEST-*.xml file 
(likely timed out) (batchId=238)
TestMetaStoreInitListener - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestMetaStoreListenersError - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestMetaStoreSchemaFactory - did not produce a TEST-*.xml file (likely timed 
out) (batchId=236)
TestMetaStoreSchemaInfo - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestMetaStoreServerUtils - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestMetastoreConf - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestMetastoreSchemaTool - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestMetrics - did not produce a TEST-*.xml file (likely timed out) (batchId=230)
TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=273)
TestMiniDruidKafkaCliDriver - did not produce a TEST-*.xml file (likely timed 
out) (batchId=273)
TestNotNullConstraint - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestObjectStore - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestObjectStoreInitRetry - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestObjectStoreSchemaMethods - did not produce a TEST-*.xml file (likely timed 
out) (batchId=238)
TestOldSchema - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestPartitionNameWhitelistValidation - did not produce a TEST-*.xml file 
(likely timed out) (batchId=230)
TestPreUpgradeTool - did not produce a TEST-*.xml file (likely timed out) 
(batchId=331)
TestPrimaryKey - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestRawStoreProxy - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestRemoteHiveMetaStore - did not produce a TEST-*.xml file (likely timed out) 
(batchId=232)
TestRemoteHiveMetaStoreIpAddress - did not produce a TEST-*.xml file (likely 
timed out) (batchId=226)
TestRemoteUGIHiveMetaStoreIpAddress - did not produce a TEST-*.xml file (likely 
timed out) (batchId=235)
TestRetriesInRetryingHMSHandler - did not produce a TEST-*.xml file (likely 
timed out) (batchId=238)
TestRetryingHMSHandler - did not produce a TEST-*.xml file (likely timed out) 
(batchId=236)
TestRuntimeStats - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestSchemaToolForMetastore - did not produce a TEST-*.xml file (likely timed 
out) (batchId=230)
TestSetUGIOnBothClientServer - did not produce a TEST-*.xml file (likely timed 
out) (batchId=229)
TestSetUGIOnOnlyClient - did not produce a TEST-*.xml file (likely timed out) 
(batchId=227)
TestSetUGIOnOnlyServer - did not produce a TEST-*.xml file (likely timed out) 
(batchId=237)
TestSparseEncodeHash - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestStats - did not produce a TEST-*.xml file (likely timed out) (batchId=230)
TestStatsSetupConst - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestTableIterable - did not produce a TEST-*.xml file (likely timed out) 
(batchId=238)
TestTablesCreateDropAlterTruncate - did not produce a TEST-*.xml file (likely 
timed out) (batchId=228)
TestTablesGetExists - did not produce a TEST-*.xml file (likely timed out) 
(batchId=230)
TestTablesList - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestTezPerfCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=273)
TestTxnHandlerNegative - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestTxnUtils - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
TestUniqueConstraint - did not produce a TEST-*.xml file (likely timed out) 
(batchId=228)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[masking_mv] (batchId=85)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mm_all] (batchId=71)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_all] 
(batchId=154)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez2]
 (batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[external_jdbc_table]
 (batchId=158)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_partitioned_2]
 (batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_partitioned_3]
 (batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_rewrite_part_2]
 (batchId=157)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[results_cache_with_masking]
 (batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_in]
 (batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_assertion_type]
 (batchId=163)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[constprog_semijoin]
 (batchId=189)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucket_map_join_tez2]
 (batchId=114)
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testManagedPaths 
(batchId=250)
org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation 
(batchId=258)
org.apache.hive.spark.client.rpc.TestRpc.testServerPort (batchId=325)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/14053/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14053/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14053/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 109 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12941303 - PreCommit-HIVE-Build

> Needs to capture input/output entities in explain
> -------------------------------------------------
>
>                 Key: HIVE-18778
>                 URL: https://issues.apache.org/jira/browse/HIVE-18778
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>            Priority: Major
>         Attachments: HIVE-18778-SparkPositive.patch, HIVE-18778.1.patch, 
> HIVE-18778.10.branch-3.patch, HIVE-18778.2.patch, HIVE-18778.3.patch, 
> HIVE-18778.4.patch, HIVE-18778.5.patch, HIVE-18778.6.patch, 
> HIVE-18778.7.patch, HIVE-18778.8.patch, HIVE-18778.9.branch-3.patch, 
> HIVE-18778.9.patch, HIVE-18778_TestCliDriver.patch, 
> HIVE-18788_SparkNegative.patch, HIVE-18788_SparkPerf.patch
>
>
> With Sentry enabled, commands like explain drop table foo fail with {{explain 
> drop table foo;}}
> {code}
> Error: Error while compiling statement: FAILED: SemanticException No valid 
> privileges
>  Required privilege( Table) not available in input privileges
>  The required privileges: (state=42000,code=40000)
> {code}
> Sentry fails to authorize because the ExplainSemanticAnalyzer uses an 
> instance of DDLSemanticAnalyzer to analyze the explain query.
> {code}
> BaseSemanticAnalyzer sem = SemanticAnalyzerFactory.get(conf, input);
> sem.analyze(input, ctx);
> sem.validate()
> {code}
> The inputs/outputs entities for this query are set in the above code. 
> However, these are never set on the instance of ExplainSemanticAnalyzer 
> itself and thus is not propagated into the HookContext in the calling Driver 
> code.
> {code}
> sem.analyze(tree, ctx); --> this results in calling the above code that uses 
> DDLSA
> hookCtx.update(sem); --> sem is an instance of ExplainSemanticAnalyzer, this 
> code attempts to update the HookContext with the input/output info from ESA 
> which is never set.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to