[
https://issues.apache.org/jira/browse/HIVE-20619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631929#comment-16631929
]
Hive QA commented on HIVE-20619:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
39s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
41s{color} | {color:blue} serde in master has 195 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
24s{color} | {color:blue} contrib in master has 13 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
15s{color} | {color:red} serde: The patch generated 85 new + 0 unchanged - 0
fixed = 85 total (was 0) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} contrib: The patch generated 0 new + 0 unchanged -
84 fixed = 0 total (was 84) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
48s{color} | {color:red} serde generated 3 new + 195 unchanged - 0 fixed = 198
total (was 195) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
31s{color} | {color:green} contrib generated 0 new + 10 unchanged - 3 fixed =
10 total (was 13) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
13s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 16s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:serde |
| | Found reliance on default encoding in
org.apache.hadoop.hive.serde2.MultiDelimitSerDe.doDeserialize(Writable):in
org.apache.hadoop.hive.serde2.MultiDelimitSerDe.doDeserialize(Writable): new
String(byte[]) At MultiDelimitSerDe.java:[line 150] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.serde2.MultiDelimitSerDe.doDeserialize(Writable):in
org.apache.hadoop.hive.serde2.MultiDelimitSerDe.doDeserialize(Writable):
String.getBytes() At MultiDelimitSerDe.java:[line 157] |
| | Found reliance on default encoding in
org.apache.hadoop.hive.serde2.MultiDelimitSerDe.doSerialize(Object,
ObjectInspector):in
org.apache.hadoop.hive.serde2.MultiDelimitSerDe.doSerialize(Object,
ObjectInspector): String.getBytes() At MultiDelimitSerDe.java:[line 181] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14102/dev-support/hive-personality.sh
|
| git revision | master / 6e27a53 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14102/yetus/diff-checkstyle-serde.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14102/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14102/yetus/new-findbugs-serde.html
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14102/yetus/patch-asflicense-problems.txt
|
| modules | C: serde contrib U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14102/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Include MultiDelimitSerDe in HIveServer2 By Default
> ---------------------------------------------------
>
> Key: HIVE-20619
> URL: https://issues.apache.org/jira/browse/HIVE-20619
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2, Serializers/Deserializers
> Affects Versions: 3.0.0, 4.0.0
> Reporter: BELUGA BEHR
> Assignee: Alice Fan
> Priority: Major
> Attachments: HIVE-20619.2.patch
>
>
> In [HIVE-20020], the hive-contrib JAR file was removed from the HiveServer2
> classpath. With this change, the {{MultiDelimitSerDe}} is no longer
> included. This is fine, because {{MultiDelimitSerDe}} was a pain in that
> environment anyway. It was available to HiveServer2, and therefore would
> work with a limited set of queries (select * from table limit 1) but any
> other query on that table which launched a MapReduce project would fail
> because the hive-contrib JAR file was not sent out with the rest of the Hive
> JARs for MapReduce jobs.
> Please bring {{MultiDelimitSerDe}} back into the fold so that it's available
> to users out of the box without having to install the hive-contrib JAR into
> the HiveServer2 auxiliary directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
