[
https://issues.apache.org/jira/browse/HIVE-20542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645995#comment-16645995
]
ASF GitHub Bot commented on HIVE-20542:
---------------------------------------
GitHub user ashutosh-bapat opened a pull request:
https://github.com/apache/hive/pull/445
HIVE-20542
Changes for HIVE-20542. There are three separate commits, with each commit
message explaining purpose of that commit. They all should be pulled together
as a single commit into Apache hive repository.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ashutosh-bapat/hive hive20542
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hive/pull/445.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #445
----
commit e76dd0d51662d5e1bc1890010b95d305f2505ea8
Author: Ashutosh Bapat <ashutosh.bapat.oss@...>
Date: 2018-10-01T05:17:06Z
HIVE-20542: Insert NULL value for columns of NOTIFICATION_LOG for which
values are not available
When no database is associated with an event we insert 'null' as database
name in the metastore.
With this commit, we insert NULL as database name.
When no tablename is associated with an event we insert an empty string as
table name in the
metastore. With this commit, we insert NULL as table name.
Even if a catalog name is associated with an event, addNotificationLog()
doesn't insert catalog in
the metastore. With this commit we take care of that as well.
Ashutosh Bapat.
commit 31aee469baffb95641fb68f70a6bcaa0ca725d28
Author: Ashutosh Bapat <ashutosh.bapat.oss@...>
Date: 2018-10-01T06:11:15Z
HIVE-20542: Modify query used to count the number of events to be
replicated incrementally
The query used to count the events for a given incremental replication does
not
1. Count event with NULL database, table or catalog names.
2. Does not consider toEventId and Limit for the given incremental
replication.
Ashutosh Bapat.
commit d3a319c5fd347018572c13b40e1e8f7cdbe72050
Author: Ashutosh Bapat <ashutosh.bapat.oss@...>
Date: 2018-10-04T04:08:44Z
HIVE-20644: Add tests for testing getNotificationEventsCount().
Ashutosh Bapat.
----
> Incremental REPL DUMP progress information log message is incorrect.
> --------------------------------------------------------------------
>
> Key: HIVE-20542
> URL: https://issues.apache.org/jira/browse/HIVE-20542
> Project: Hive
> Issue Type: Bug
> Components: repl
> Affects Versions: 4.0.0, 3.2.0
> Reporter: Sankar Hariappan
> Assignee: Ashutosh Bapat
> Priority: Minor
> Labels: DR, Replication, pull-request-available
> Attachments: HIVE-20542.01.patch
>
>
> Incremental REPL DUMP have the progress information logged as
> "eventsDumpProgress":"49/0".
> It should actually log the estimated number of events are denominator but it
> is coming as 0 always.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
