[ 
https://issues.apache.org/jira/browse/HIVE-20679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654295#comment-16654295
 ] 

Hive QA commented on HIVE-20679:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
54s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
30s{color} | {color:blue} common in master has 65 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m 
24s{color} | {color:blue} standalone-metastore/metastore-common in master has 
28 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
26s{color} | {color:blue} hcatalog/server-extensions in master has 1 extant 
Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
40s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs 
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
55s{color} | {color:blue} ql in master has 2318 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m  
7s{color} | {color:blue} standalone-metastore/metastore-server in master has 
182 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
25s{color} | {color:blue} testutils/ptest2 in master has 24 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m  
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
17s{color} | {color:red} server-extensions in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
18s{color} | {color:red} hcatalog-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
38s{color} | {color:red} hive-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
33s{color} | {color:red} ql in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
17s{color} | {color:red} server-extensions in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
40s{color} | {color:red} hive-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 17s{color} 
| {color:red} server-extensions in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 40s{color} 
| {color:red} hive-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
10s{color} | {color:red} hcatalog/server-extensions: The patch generated 1 new 
+ 23 unchanged - 2 fixed = 24 total (was 25) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
22s{color} | {color:red} itests/hive-unit: The patch generated 34 new + 814 
unchanged - 36 fixed = 848 total (was 850) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
37s{color} | {color:red} ql: The patch generated 5 new + 36 unchanged - 5 fixed 
= 41 total (was 41) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git 
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
17s{color} | {color:red} server-extensions in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
35s{color} | {color:red} hive-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  
8s{color} | {color:red} standalone-metastore/metastore-server generated 5 new + 
180 unchanged - 2 fixed = 185 total (was 182) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
51s{color} | {color:green} metastore-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
14s{color} | {color:red} hcatalog_server-extensions generated 7 new + 1 
unchanged - 0 fixed = 8 total (was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
14s{color} | {color:green} hcatalog-unit in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} hive-unit in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} ql in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} standalone-metastore_metastore-server generated 0 
new + 47 unchanged - 2 fixed = 47 total (was 49) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
8s{color} | {color:green} ptest2 in the patch passed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
13s{color} | {color:red} The patch generated 5 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 36s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
|  |  Write to static field 
org.apache.hadoop.hive.metastore.messaging.MessageBuilder.paramsFilter from 
instance method 
org.apache.hadoop.hive.metastore.messaging.MessageBuilder.init()  At 
MessageBuilder.java:from instance method 
org.apache.hadoop.hive.metastore.messaging.MessageBuilder.init()  At 
MessageBuilder.java:[line 154] |
|  |  Private method 
org.apache.hadoop.hive.metastore.messaging.MessageBuilder.getJsonTree(NotificationEvent)
 is never called  At MessageBuilder.java:called  At MessageBuilder.java:[line 
341] |
|  |  input must be non-null but is marked as nullable  At 
MessageBuilder.java:is marked as nullable  At MessageBuilder.java:[line 426] |
|  |  Found reliance on default encoding in 
org.apache.hadoop.hive.metastore.messaging.json.gzip.DeSerializer.deCompress(String):in
 
org.apache.hadoop.hive.metastore.messaging.json.gzip.DeSerializer.deCompress(String):
 String.getBytes()  At DeSerializer.java:[line 43] |
|  |  Found reliance on default encoding in 
org.apache.hadoop.hive.metastore.messaging.json.gzip.Serializer.serialize(EventMessage):in
 
org.apache.hadoop.hive.metastore.messaging.json.gzip.Serializer.serialize(EventMessage):
 String.getBytes()  At Serializer.java:[line 22] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14528/dev-support/hive-personality.sh
 |
| git revision | master / 3c70302 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-mvninstall-hcatalog_server-extensions.txt
 |
| mvninstall | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-mvninstall-itests_hcatalog-unit.txt
 |
| mvninstall | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-mvninstall-itests_hive-unit.txt
 |
| mvninstall | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-mvninstall-ql.txt
 |
| compile | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-compile-hcatalog_server-extensions.txt
 |
| compile | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-compile-itests_hive-unit.txt
 |
| javac | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-compile-hcatalog_server-extensions.txt
 |
| javac | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-compile-itests_hive-unit.txt
 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/diff-checkstyle-hcatalog_server-extensions.txt
 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/diff-checkstyle-itests_hive-unit.txt
 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/diff-checkstyle-ql.txt
 |
| whitespace | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/whitespace-eol.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-findbugs-hcatalog_server-extensions.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-findbugs-itests_hive-unit.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/new-findbugs-standalone-metastore_metastore-server.html
 |
| javadoc | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/diff-javadoc-javadoc-hcatalog_server-extensions.txt
 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus/patch-asflicense-problems.txt
 |
| modules | C: common standalone-metastore/metastore-common 
hcatalog/server-extensions itests/hcatalog-unit itests/hive-unit ql 
standalone-metastore/metastore-server testutils/ptest2 U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-14528/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> DDL operations on hive might create large messages for DBNotification
> ---------------------------------------------------------------------
>
>                 Key: HIVE-20679
>                 URL: https://issues.apache.org/jira/browse/HIVE-20679
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: anishek
>            Assignee: anishek
>            Priority: Major
>         Attachments: HIVE-20679.1.patch, HIVE-20679.2.patch, 
> HIVE-20679.3.patch, HIVE-20679.4.patch, HIVE-20679.5.patch, 
> HIVE-20679.6.patch, a.sql, b.sql
>
>
> Certain type of ddl operations might create large messages as part of 
> DBNoitification, this might lead to the rdbms throwing an error when storing 
> the message since its size is to large. It will also increase the footprint 
> of the rdbms space usage. 
> We should try store compressed messages to allow handling these situations. 
> Edit: For notification_log table the message column for all supported 
> databases can store messages from 2GB to 4GB



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to