[ 
https://issues.apache.org/jira/browse/HIVE-20701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655686#comment-16655686
 ] 

Prasanth Jayachandran commented on HIVE-20701:
----------------------------------------------

nit: long tableId = conn.getMSC().getTable(conn.getTable().getDbName(), 
conn.getTable().getTableName()).getId();

This tableId does not change within a streaming connection right? Maybe this 
can be a variable in streaming connection or transaction batch since we already 
have the table object (also avoids additional metastore call during commit).

Looks good otherwise. +1

> Allow HiveStreaming to receive a key value to commit atomically together with 
> the transaction
> ---------------------------------------------------------------------------------------------
>
>                 Key: HIVE-20701
>                 URL: https://issues.apache.org/jira/browse/HIVE-20701
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jaume M
>            Assignee: Jaume M
>            Priority: Major
>         Attachments: HIVE-20701.1.patch, HIVE-20701.2.patch, 
> HIVE-20701.3.patch, HIVE-20701.4.patch, HIVE-20701.5.patch
>
>
> Following up with HIVE-20538 it'd be nice to be able to use this feature with 
> hive streaming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to