[
https://issues.apache.org/jira/browse/HIVE-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635948#comment-14635948
]
Sergey Shelukhin edited comment on HIVE-11259 at 7/21/15 10:33 PM:
-------------------------------------------------------------------
1) These classes existed before, I will see if they can be merged.
2) I don't think removing intrinsic linked list is a good idea, there are
problems with java LinkedList - it's hard to keep pointer to an element and
modify it in place in general; also, as soon as list is modified all the
iterators are invalidated; so, for example, reading multiple columns RG by RG,
keeping the pointer to end of last RG (where nexr RG, that may be in separate
buffer due to SARG filtering, starts) becomes impossible - as soon as one
column read replaces buffer chunk with cache chunk, iterators for all other
columns become invalid. TreeMap will have the same problem as far as I can
tell. It's really not that complicated to have a linked list, if Java was a
real programming language we could even make it an aspect sort of thing via
multiple inheritance :)
3) Ok
was (Author: sershe):
1) These classes existed before, I will see if they can be merged.
2) I don't think removing intrinsic linked list is a good idea, there are
problems with java LinkedList - it's hard to keep pointer to an element, as
soon as list is modified all the iterators are invalidated. So for example
reading multiple columns RG by RG, keeping the pointer to end of last RG (where
nexr RG, that may be in separate buffer due to SARG filtering, starts) becomes
impossible - as soon as one column read replaces buffer chunk with cache chunk,
pointers for all other columns become invalid. TreeMap will have the same
problem as far as I can tell. It's really not that complicated to have a linked
list, if Java was a real programming language we could even make it an aspect
sort of thing via multiple inheritance :)
3) Ok
> LLAP: clean up ORC dependencies part 1
> --------------------------------------
>
> Key: HIVE-11259
> URL: https://issues.apache.org/jira/browse/HIVE-11259
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-11259.patch
>
>
> Before there's storage handler module, we can clean some things up
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
