[ https://issues.apache.org/jira/browse/HIVE-20868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679573#comment-16679573 ]
Hive QA commented on HIVE-20868: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 34s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 41s{color} | {color:blue} ql in master has 2315 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 52s{color} | {color:red} ql generated 1 new + 2315 unchanged - 0 fixed = 2316 total (was 2315) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 21m 41s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | org.apache.hadoop.hive.ql.exec.TezDummyStoreOperator is Serializable; consider declaring a serialVersionUID At TezDummyStoreOperator.java:a serialVersionUID At TezDummyStoreOperator.java:[lines 33-64] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14807/dev-support/hive-personality.sh | | git revision | master / ad597b0 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14807/yetus/new-findbugs-ql.html | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14807/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > SMB Join fails intermittently when TezDummyOperator has child op in > getFinalOp in MapRecordProcessor > ---------------------------------------------------------------------------------------------------- > > Key: HIVE-20868 > URL: https://issues.apache.org/jira/browse/HIVE-20868 > Project: Hive > Issue Type: Bug > Reporter: Deepak Jaiswal > Assignee: Deepak Jaiswal > Priority: Major > Attachments: HIVE-20868.1.patch, HIVE-20868.2.patch > > > In MapRecordProcessor::getFinalOp() due to external cause(not known), the > TezDummyStoreOperator may have MergeJoin Op as child intermittently. Due to > this, the fetchDone remains set to true for the DummyOp which was set by > previous task. Ideally, fetchDone should be reset for each task. This > eventually leads to the join op skip rows from that dummy op resulting in > wrong results. > Good init order > {code} > 2018-11-01 21:42:33,677 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = TS[3] (core) > 2018-11-01 21:42:33,677 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = FIL[24] > 2018-11-01 21:42:33,677 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = SEL[5] > 2018-11-01 21:42:33,677 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = DUMMY_STORE[45] > 2018-11-01 21:42:33,677 [INFO] [TezChild] |tez.MapRecordProcessor|: Iterating > children of dummy op DUMMY_STORE[45] > 2018-11-01 21:42:33,677 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp returns DUMMY_STORE[45] > 2018-11-01 21:42:33,677 [INFO] [TezChild] |tez.MapRecordProcessor|: > InitProcessor : setting fetchDone to false > {code} > Bad init order > {code} > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = TS[3] (core) > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = FIL[24] > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = SEL[5] > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = DUMMY_STORE[45] > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: > Iterating children of dummy op DUMMY_STORE[45] > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: Child of > Dummy Op MERGEJOIN[44] > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = MERGEJOIN[44] > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = SEL[13] > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp child Ops = RS[14] > 2018-11-01 21:42:33,304 [INFO] [TezChild] |tez.MapRecordProcessor|: > getFinalOp returns RS[14] > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)