[
https://issues.apache.org/jira/browse/HIVE-20906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684389#comment-16684389
]
Hive QA commented on HIVE-20906:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12947863/ephemeral.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15538 tests
executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.authorization.TestJdbcMetadataApiAuth.org.apache.hive.jdbc.authorization.TestJdbcMetadataApiAuth
(batchId=262)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14893/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14893/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14893/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12947863 - PreCommit-HIVE-Build
> Hive locks are not really ephemeral
> -----------------------------------
>
> Key: HIVE-20906
> URL: https://issues.apache.org/jira/browse/HIVE-20906
> Project: Hive
> Issue Type: Bug
> Affects Versions: 2.3.0, 2.3.3, 3.1.1
> Reporter: Rajesh KSV
> Priority: Major
> Fix For: 3.1.1
>
> Attachments: ephemeral.patch
>
>
> I am using Hive 2.3.3.
>
> According to docs
> ([https://cwiki.apache.org/confluence/display/Hive/Locking]), they are
> ephemeral. But in the Zookeeper and Hive source Code, they seemed to be
> non-ephemeral.
>
> I ran the following query in Hive.
>
> *lock table discovery.defaultns*
>
> When I see the lock in zookeeper, it doesn't look like ephemeral node.
>
> [zk: localhost:2181(CONNECTED) 55] get
> /hive_zookeeper_namespace/discovery/defaultns/LOCK-EXCLUSIVE-0000000000
>
> hive_20181112191555_d6640955-2806-4fa7-9e52-30d04c377a04:1542030355565:EXPLICIT:lock
> table discovery.defaultns exclusive:10.33.222.139
> cZxid = 0x2400296808
> ctime = Mon Nov 12 19:15:55 IST 2018
> mZxid = 0x2400296808
> mtime = Mon Nov 12 19:15:55 IST 2018
> pZxid = 0x2400296808
> cversion = 0
> dataVersion = 0
> aclVersion = 0
> *ephemeralOwner = 0x0*
> dataLength = 134
> numChildren = 0
>
> Also in the code -
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java],
> the lock is KeepAlive/PERSISTENT and not EPHIMERAL. Current code is
>
> *HiveLock lck = lockMgr.lock(new HiveLockObject(tbl, lockData), mode,
> true);*
> Instead it should be
> *HiveLock lck = lockMgr.lock(new HiveLockObject(tbl, lockData), mode,
> false);*
> The patch is the same.
> Please correct me if I am wrong. This is my first ever Jira/Patch in Hive
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
