[ 
https://issues.apache.org/jira/browse/HIVE-20916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688828#comment-16688828
 ] 

Hive QA commented on HIVE-20916:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12948398/HIVE-20916.03.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15544 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/14953/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14953/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14953/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12948398 - PreCommit-HIVE-Build

> Fix typo in JSONCreateDatabaseMessage and add test for alter database
> ---------------------------------------------------------------------
>
>                 Key: HIVE-20916
>                 URL: https://issues.apache.org/jira/browse/HIVE-20916
>             Project: Hive
>          Issue Type: Bug
>          Components: Standalone Metastore
>    Affects Versions: 4.0.0
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Minor
>         Attachments: HIVE-20916.01.patch, HIVE-20916.02.patch, 
> HIVE-20916.03.patch
>
>
> {code}
> public JSONCreateDatabaseMessage(String server, String servicePrincipal, 
> Database db,
>       Long timestamp) {
>     this.server = server;
>     this.servicePrincipal = servicePrincipal;
>     this.db = db.getName();
>     this.timestamp = timestamp;
>     try {
>       this.dbJson = MessageBuilder.createDatabaseObjJson(db);
>     } catch (TException ex) {
>       throw new IllegalArgumentException("Could not serialize Function 
> object", ex);
>     }
>     checkValid();
>   }
> {code}
> The exception message should say Database instead of Function. Also, the 
> {{TestDbNotificationListener#createDatabase}} should be modified to make sure 
> that the deserialized database object from the dbJson field matches with the 
> original database object 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to