[ https://issues.apache.org/jira/browse/HIVE-20919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689201#comment-16689201 ]
Hive QA commented on HIVE-20919: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12948460/HIVE-20919.06.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 15543 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_limit] (batchId=182) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropParitionsCleanup (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSqlErrorMetrics (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testMaxEventResponse (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testPartitionOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testQueryCloseOnError (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testRoleOps (batchId=232) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14959/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14959/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14959/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12948460 - PreCommit-HIVE-Build > Break up UpdateDeleteSemanticAnalyzer > ------------------------------------- > > Key: HIVE-20919 > URL: https://issues.apache.org/jira/browse/HIVE-20919 > Project: Hive > Issue Type: Improvement > Components: Transactions > Affects Versions: 3.2.0 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Fix For: 3.2.0 > > Attachments: HIVE-20919.01.patch, HIVE-20919.02.patch, > HIVE-20919.03.patch, HIVE-20919.04.patch, HIVE-20919.05.patch, > HIVE-20919.06.patch > > > UpdateDeleteSemanticAnalyzer handles update, delete, acid export and merge > queries by rewriting them to a different form. This is a clear violation of > [SRP|https://en.wikipedia.org/wiki/Single_responsibility_principle], and > therefore needs to be refactored. An abstract ancestor needs to take the > common part, and each of the specific tasks should be handled by a separate > class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)