[
https://issues.apache.org/jira/browse/HIVE-20953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694385#comment-16694385
]
ASF GitHub Bot commented on HIVE-20953:
---------------------------------------
GitHub user ashutosh-bapat opened a pull request:
https://github.com/apache/hive/pull/491
HIVE-20953: Fix testcase TestReplicationScenariosAcrossInstances#test…
Fix testcase
TestReplicationScenariosAcrossInstances#testBootstrapReplLoadRetryAfterFailureForPartitions
to not depend upon the order in which objects get loaded.
@anishek or @maheshk114 can you please review the change?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ashutosh-bapat/hive hive20953
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hive/pull/491.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #491
----
commit 5c9a72bd5f772b7cefdc86c397a7771c2059043a
Author: Ashutosh Bapat <ashutosh.bapat.oss@...>
Date: 2018-11-21T08:25:38Z
HIVE-20953: Fix testcase
TestReplicationScenariosAcrossInstances#testBootstrapReplLoadRetryAfterFailureForPartitions
to not depend upon the order in which objects get loaded
Ashutosh Bapat
----
> Fix testcase
> TestReplicationScenariosAcrossInstances#testBootstrapReplLoadRetryAfterFailureForPartitions
> to not depend upon the order in which objects get loaded
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-20953
> URL: https://issues.apache.org/jira/browse/HIVE-20953
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 4.0.0
> Reporter: Ashutosh Bapat
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The testcase is intended to test REPL LOAD with retry. The test creates a
> partitioned table and a function in the source database and loads those to
> the replica. The first attempt to load a dump is intended to fail while
> loading one of the partitions. Based on the order in which the objects get
> loaded, if the function is queued after the table, it will not be available
> in replica after the load failure. But if it's queued before the table, it
> will be available in replica even after the load failure. The test assumes
> the later case, which may not be true always.
>
> Hence fix the testcase to order the objects by a fixed ordering. By setting
> hive.in.repl.test.files.sorted to true, the objects are ordered by the
> directory names. This
> ordering is available with minimal changes for testing, hence we use it.
> With this ordering a
> function gets loaded before a table. So changed the test to not expect the
> function to be available after the failed load, but be available after the
> retry
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
