[ https://issues.apache.org/jira/browse/HIVE-20961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712931#comment-16712931 ]
Hive QA commented on HIVE-20961: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12950964/HIVE-20961.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 15650 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_predicate_pushdown] (batchId=262) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constantPropWhen] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_case] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_when] (batchId=30) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_memcheck] (batchId=45) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_ppd_key_range] (batchId=103) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_pushdown] (batchId=103) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_limit] (batchId=182) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15210/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15210/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15210/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12950964 - PreCommit-HIVE-Build > Retire NVL implementation > ------------------------- > > Key: HIVE-20961 > URL: https://issues.apache.org/jira/browse/HIVE-20961 > Project: Hive > Issue Type: Improvement > Reporter: Zoltan Haindrich > Assignee: Laszlo Bodor > Priority: Major > Attachments: HIVE-20961.01.patch, HIVE-20961.02.patch > > > Right now we have coalesce and nvl implemented separetly; it might be better > to remove one of them as they are doing the same. Because Coalesce is in the > standard - I think NVL have to go...and became an alias to Coalesce. > Further benefit is: that optimizations which coalesce already recieves; will > be done on NVL calls as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)