[ 
https://issues.apache.org/jira/browse/HIVE-16100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713410#comment-16713410
 ] 

Vineet Garg commented on HIVE-16100:
------------------------------------

I realized that earlier patch provided by [~gopalv] was trying to fix two 
different problems 1) SDPO losing sibling and 2) reducer de-dup incorrectly 
removing branch.
 Fix for 2) issue is causing correctness issues in order by queries (e.g. 
mm_all.q).
 IMHO we should first fix 1) and then investigate and fix 2) in separate JIRA. 

I have uploaded a new [^HIVE-16100.8.patch] which should fix stats auto gather 
problem with SDPO. Let us use HIVE-17020 to fix 2)

> Dynamic Sorted Partition optimizer loses sibling operators
> ----------------------------------------------------------
>
>                 Key: HIVE-16100
>                 URL: https://issues.apache.org/jira/browse/HIVE-16100
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Planning
>    Affects Versions: 1.2.1, 2.1.1, 2.2.0
>            Reporter: Gopal V
>            Assignee: Vineet Garg
>            Priority: Major
>         Attachments: HIVE-16100.1.patch, HIVE-16100.2.patch, 
> HIVE-16100.2.patch, HIVE-16100.3.patch, HIVE-16100.4.patch, 
> HIVE-16100.5.patch, HIVE-16100.6.patch, HIVE-16100.7.patch, HIVE-16100.8.patch
>
>
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java#L173
> {code}
>       // unlink connection between FS and its parent
>       fsParent = fsOp.getParentOperators().get(0);
>       fsParent.getChildOperators().clear();
> {code}
> The optimizer discards any cases where the fsParent has another SEL child 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to