[ https://issues.apache.org/jira/browse/HIVE-21005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716316#comment-16716316 ]
Gopal V commented on HIVE-21005: -------------------------------- LGTM - +1 > LLAP: Reading more stripes per-split leaks ZlibCodecs > ----------------------------------------------------- > > Key: HIVE-21005 > URL: https://issues.apache.org/jira/browse/HIVE-21005 > Project: Hive > Issue Type: Bug > Components: llap > Reporter: Gopal V > Assignee: Nita Dembla > Priority: Major > Attachments: HIVE-21005.patch > > > OrcEncodedDataReader - calls ensureDataReader in a loop, overwriting itself > {code} > for (int stripeIxMod = 0; stripeIxMod < stripeRgs.length; ++stripeIxMod) { > .... > // 6.2. Ensure we have stripe metadata. We might have read it before > for RG filtering. > if (stripeMetadatas != null) { > stripeMetadata = stripeMetadatas.get(stripeIxMod); > } else { > ... > ensureDataReader(); > ... > } > {code} > {code} > private void ensureDataReader() throws IOException { > ... > stripeReader = orcReader.encodedReader( > fileKey, dw, dw, useObjectPools ? POOL_FACTORY : null, trace, > useCodecPool, cacheTag); > {code} > creates new encodedReader without closing previous stripe's encoded reader. -- This message was sent by Atlassian JIRA (v7.6.3#76005)