[ 
https://issues.apache.org/jira/browse/HIVE-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644047#comment-14644047
 ] 

Jesus Camacho Rodriguez commented on HIVE-11316:
------------------------------------------------

[~hsubramaniyan], can we create the new interface to keep the original 
toStringTree as in patch#3, but override the methods so any mutation in the 
tree invalidates the memoized String as in patch#4? I think that should get us 
the best of both worlds.

> Use datastructure that doesnt duplicate any part of string for 
> ASTNode::toStringTree()
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-11316
>                 URL: https://issues.apache.org/jira/browse/HIVE-11316
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-11316-branch-1.0.patch, 
> HIVE-11316-branch-1.2.patch, HIVE-11316.1.patch, HIVE-11316.2.patch, 
> HIVE-11316.3.patch, HIVE-11316.4.patch, HIVE-11316.5.patch, HIVE-11316.6.patch
>
>
> HIVE-11281 uses an approach to memoize toStringTree() for ASTNode. This jira 
> is suppose to alter the string memoization to use a different data structure 
> that doesn't duplicate any part of the string so that we do not run into OOM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to