[
https://issues.apache.org/jira/browse/HIVE-21033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729105#comment-16729105
]
Hive QA commented on HIVE-21033:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12953077/HIVE-21033.2.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/15434/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15434/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15434/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-12-26 17:03:03.046
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-15434/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-12-26 17:03:03.049
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 926c1e8 HIVE-20936 Allow the Worker thread in the metastore to
run outside of it (Jaume Marhuenda via Eugene Koifman)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 926c1e8 HIVE-20936 Allow the Worker thread in the metastore to
run outside of it (Jaume Marhuenda via Eugene Koifman)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-12-26 17:03:03.759
+ rm -rf ../yetus_PreCommit-HIVE-Build-15434
+ mkdir ../yetus_PreCommit-HIVE-Build-15434
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-15434
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-15434/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: a/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java: does not exist
in index
error: a/cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java:
does not exist in index
error:
a/common/src/java/org/apache/hadoop/hive/common/io/CachingPrintStream.java:
does not exist in index
error: a/common/src/java/org/apache/hadoop/hive/common/io/FetchConverter.java:
does not exist in index
error:
a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java:
does not exist in index
error:
a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestCLIAuthzSessionContext.java:
does not exist in index
error: a/itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java:
does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java: does
not exist in index
error:
a/ql/src/test/org/apache/hadoop/hive/ql/processors/TestSetProcessor.java: does
not exist in index
error:
a/service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java:
does not exist in index
error:
a/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:
does not exist in index
Going to apply patch with: git apply -p1
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q
-Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: executing: [/tmp/protoc5620331673436136816.exe, --version]
libprotoc 2.5.0
protoc-jar: executing: [/tmp/protoc5620331673436136816.exe,
-I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore,
--java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources,
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto]
ANTLR Parser Generator Version 3.5.2
protoc-jar: executing: [/tmp/protoc5466428964218251607.exe, --version]
libprotoc 2.5.0
ANTLR Parser Generator Version 3.5.2
Output file
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/target/generated-sources/org/apache/hadoop/hive/metastore/parser/FilterParser.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g
org/apache/hadoop/hive/metastore/parser/Filter.g
log4j:WARN No appenders could be found for logger (DataNucleus.Persistence).
log4j:WARN Please initialize the log4j system properly.
DataNucleus Enhancer (version 4.1.17) for API "JDO"
DataNucleus Enhancer completed with success for 41 classes.
ANTLR Parser Generator Version 3.5.2
Output file
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
org/apache/hadoop/hive/ql/parse/HiveLexer.g
Output file
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveParser.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
org/apache/hadoop/hive/ql/parse/HiveParser.g
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:808:14:
Decision can match input such as "KW_EXTENDED" using multiple alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK KW_DATETIME" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK KW_DATE {LPAREN, StringLiteral}"
using multiple alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK KW_UNIONTYPE LESSTHAN" using
multiple alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK {KW_EXISTS, KW_TINYINT}" using
multiple alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK KW_STRUCT LESSTHAN" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:424:5:
Decision can match input such as "KW_UNKNOWN" using multiple alternatives: 1, 10
As a result, alternative(s) 10 were disabled for that input
Output file
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HintParser.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g
org/apache/hadoop/hive/ql/parse/HintParser.g
Generating vector expression code
Generating vector expression test code
Processing annotations
Annotations processed
Processing annotations
No elements to process
Processing annotations
Annotations processed
Processing annotations
No elements to process
Processing annotations
Annotations processed
Processing annotations
No elements to process
Dec 26, 2018 5:06:54 PM org.apache.jasper.servlet.TldScanner scanJars
INFO: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug
logging for this logger for a complete list of JARs that were scanned but no
TLDs were found in them. Skipping unneeded JARs during scanning can improve
startup time and JSP compilation time.
[ERROR] COMPILATION ERROR :
[ERROR]
/data/hiveptest/working/apache-github-source-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatCli.java:[73,16]
incompatible types: java.io.PrintStream cannot be converted to
org.apache.hadoop.hive.common.io.SessionStream
[ERROR]
/data/hiveptest/working/apache-github-source-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatCli.java:[74,16]
incompatible types: java.io.PrintStream cannot be converted to
org.apache.hadoop.hive.common.io.SessionStream
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile)
on project hive-hcatalog-core: Compilation failure: Compilation failure:
[ERROR]
/data/hiveptest/working/apache-github-source-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatCli.java:[73,16]
incompatible types: java.io.PrintStream cannot be converted to
org.apache.hadoop.hive.common.io.SessionStream
[ERROR]
/data/hiveptest/working/apache-github-source-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatCli.java:[74,16]
incompatible types: java.io.PrintStream cannot be converted to
org.apache.hadoop.hive.common.io.SessionStream
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :hive-hcatalog-core
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-15434
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12953077 - PreCommit-HIVE-Build
> Forgetting to close operation cuts off any more HiveServer2 output
> ------------------------------------------------------------------
>
> Key: HIVE-21033
> URL: https://issues.apache.org/jira/browse/HIVE-21033
> Project: Hive
> Issue Type: Bug
> Reporter: Szehon Ho
> Assignee: Szehon Ho
> Priority: Major
> Attachments: HIVE-21033.2.patch, HIVE-21033.patch
>
>
> We had a custom client that did not handle closing the operations, until the
> end of the session. it is a mistake in the client, but it reveals kind of a
> vulnerability in HiveServer2
> This happens if you have a session with (1) HiveCommandOperation and (2)
> SQLOperation and don't close them right after. For example a session that
> does the operations (set a=b; select * from foobar; ).
> When SQLOperation runs , it set SessionState.out and err to be System.out and
> System.err . Ref:
> [SQLOperation#setupSessionIO|https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java#L139]
> Then the client closes the session, or disconnects which triggers
> closeSession() on the Thrift side. In this case, the closeSession closes all
> the operations, starting with HiveCommandOperation. This closes all the
> streams, which is System.out and System.err as set by SQLOperation earlier.
> Ref:
> [HiveCommandOperation#tearDownSessionIO|https://github.com/apache/hive/blob/f37c5de6c32b9395d1b34fa3c02ed06d1bfbf6eb/service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java#L101]
>
> After this, no more HiveServer2 output appears as System.out and System.err
> are closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
