[
https://issues.apache.org/jira/browse/HIVE-21052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745593#comment-16745593
]
Eugene Koifman commented on HIVE-21052:
---------------------------------------
[~jmarhuen], I'm not sure I understand your 1st 2 bullet points. we currently
only support auto-commit mode and all the locks for a given statement are
processed in a single call to {{lock(LockRequest rqst)}} so you should see the
full set of tables and corresponding {{writeID}}. So in the absence of retries
(of the HMS call), I'd expect TXN_COMPONENTS to have a single 'p' type row for
a given (table, txn) combination. (Implicitly, each table gets only 1
{{writeID}} within a given txn.)
Are we saying the same thing?
If retries cause multiple p-type entires for (table, txn) that should be
harmless. As you say, Initiator would only make 1 {{COMPACTION_QUEUE}} entry
and {{Cleaner}} will clean data for all aborted txns for a given table based on
that queue entry.
> Make sure transactions get cleaned if they are aborted before addPartitions
> is called
> -------------------------------------------------------------------------------------
>
> Key: HIVE-21052
> URL: https://issues.apache.org/jira/browse/HIVE-21052
> Project: Hive
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 3.0.0
> Reporter: Jaume M
> Assignee: Jaume M
> Priority: Critical
> Attachments: Aborted Txn w_Direct Write.pdf, HIVE-21052.1.patch,
> HIVE-21052.2.patch, HIVE-21052.3.patch, HIVE-21052.4.patch,
> HIVE-21052.5.patch, HIVE-21052.6.patch, HIVE-21052.7.patch
>
>
> If the transaction is aborted between openTxn and addPartitions and data has
> been written on the table the transaction manager will think it's an empty
> transaction and no cleaning will be done.
> This is currently an issue in the streaming API and in micromanaged tables.
> As proposed by [~ekoifman] this can be solved by:
> * Writing an entry with a special marker to TXN_COMPONENTS at openTxn and
> when addPartitions is called remove this entry from TXN_COMPONENTS and add
> the corresponding partition entry to TXN_COMPONENTS.
> * If the cleaner finds and entry with a special marker in TXN_COMPONENTS that
> specifies that a transaction was opened and it was aborted it must generate
> jobs for the worker for every possible partition available.
> cc [~ewohlstadter]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
